cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

merge /team layout with user layout

Open gitstart opened this issue 2 years ago • 4 comments

What does this PR do?

Fixes #4316

Environment: Staging(main branch) / Production

Loom video: https://www.loom.com/share/f7bef9fb34964ab1828990fa8e29636e

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Chore (refactoring code, technical debt, workflow improvements)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

gitstart avatar Nov 14 '22 09:11 gitstart

@gitstart is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 14 '22 09:11 vercel[bot]

  • Added name and username props to HeadSeoProps
  • Imported PublicPage from pages/[user] instead of components/team/screens/Team
  • Removed useTheme() hook call in TeamPage function, replaced with user?.theme || "light" as argument for useTheme(...) hook call (useMeQuery is used)
  • Replaced getPlaceholderAvatar(...), CAL_URL + "/" + ... with avatar: CAL_URL + "/" + ... inside team object returned by getServerSideProps async function

what-the-diff[bot] avatar Nov 14 '22 09:11 what-the-diff[bot]

@JeroenReumkens can you investigate if this is useful for the new booking page refactor? if yes, please approve, if no, close.

PeerRich avatar Dec 02 '22 10:12 PeerRich

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 10:16AM (UTC)

vercel[bot] avatar Dec 02 '22 10:12 vercel[bot]

Hey @gitstart Thanks a lot for this contribution! 🙏 I'm currently working in rewriting the full layout of the booking pages, and I think it will be very hard to merge these two changes. I will however look into your changes and take in any changes that are valuable to have, so your work isn't wasted. Hope you understand 🫶

— Jeroen.

JeroenReumkens avatar Dec 19 '22 11:12 JeroenReumkens