cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: position of badges

Open Udit-takkar opened this issue 3 years ago • 1 comments

fixes: #4649

Screenshot 2022-09-22 at 2 00 22 AM

Udit-takkar avatar Sep 21 '22 20:09 Udit-takkar

@Udit-takkar is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 21 '22 20:09 vercel[bot]

Screenshot 2022-09-22 at 10 06 38 AM I think we should show the label in mobile mode as well. cc @Jaibles for the design

hariombalhara avatar Sep 22 '22 04:09 hariombalhara

We should definitely show the label on mobile. As well as the date & time. We have designs for this here.

CleanShot 2022-09-22 at 09 17 13@2x

It would be great to also test this with recurring bookings.

ciaranha avatar Sep 22 '22 08:09 ciaranha

ok

Udit-takkar avatar Sep 23 '22 20:09 Udit-takkar

Screenshot 2022-09-24 at 6 11 28 PM

should i also change the button(Edit booking) like you have done here ?

Udit-takkar avatar Sep 24 '22 12:09 Udit-takkar

Screenshot 2022-09-24 at 6 56 41 PM

build this for mobile view

Udit-takkar avatar Sep 24 '22 12:09 Udit-takkar

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 27, 2022 at 0:26AM (UTC)

vercel[bot] avatar Sep 24 '22 13:09 vercel[bot]

@Udit-takkar left a comment re: not using <br> for layouting

PeerRich avatar Sep 24 '22 13:09 PeerRich

done

Udit-takkar avatar Sep 24 '22 17:09 Udit-takkar

Just a FYI @Udit-takkar @PeerRich this PR is what currently breaking our E2E tests. We're introducing duplicate markdown and displaying it with breakpoints and Playwright doesn't like that.

zomars avatar Sep 29 '22 12:09 zomars