cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

/settings sidebar doesn't match figma designs

Open ciaranha opened this issue 1 year ago • 4 comments

There are some subtleties to spacing in the settings sidebar that make it easier to scan, particularly the sectioning of different settings areas that are not reflected from the Figma designs.

View in Figma

CleanShot 2022-09-20 at 22 06 16@2x

ciaranha avatar Sep 20 '22 21:09 ciaranha

Can i work on this?

harshsinghatz avatar Sep 21 '22 04:09 harshsinghatz

Yep go ahead @harshsinghatz

ciaranha avatar Sep 21 '22 06:09 ciaranha

Sure

harshsinghatz avatar Sep 21 '22 06:09 harshsinghatz

Screenshot 2022-09-22 at 2 04 25 AM

one more thing in mobile sidebar the team logo is not centered in teams.

Udit-takkar avatar Sep 21 '22 20:09 Udit-takkar

I will take a look at that as well!

harshsinghatz avatar Sep 22 '22 08:09 harshsinghatz

Hey is anyone working on this issue or can I work on this one ?

AdityaPainuli avatar Sep 25 '22 03:09 AdityaPainuli

Hey is anyone working on this issue or can I work on this one ?

Currently, I am working on it

harshsinghatz avatar Sep 25 '22 03:09 harshsinghatz

Hey is anyone working on this issue or can I work on this one ?

Currently, I am working on it

Ok no worries 👍

AdityaPainuli avatar Sep 25 '22 03:09 AdityaPainuli

There's also a line-height issue with the nav items causing it to not be vertically centered.

35e7a9ac-dc46-473b-ab9b-9a3ca5bf6fb2

ciaranha avatar Nov 21 '22 14:11 ciaranha

@Jaibles Got it!, is it a priority fix? or can i do this in a few days? Because currently my exams are going on, so i would be active after the exams are done!

harshsinghatz avatar Nov 21 '22 14:11 harshsinghatz

in a few days is ok! thanks @harshsinghatz 🙏 and good luck in the exams :)

ciaranha avatar Nov 21 '22 14:11 ciaranha

@Udit-takkar fancy having a go at this one? There were improvements made previously but the app still doesn't match the designs.

ciaranha avatar Dec 22 '22 13:12 ciaranha