cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Published 20 hours ago • verified publisher icon calcom

Dark theme support required for button component

Open hariombalhara opened this issue 2 years ago • 4 comments

https://www.loom.com/share/a7545b343c8043268dfe270040fb0628

hariombalhara avatar Sep 17 '22 02:09 hariombalhara

Hi can I fix this?

hussamkhatib avatar Sep 18 '22 10:09 hussamkhatib

@hussamkhatib Sure. You just need to make sure that the buttons inside the app(logged in area) are not in the dark mode. This is required because app doesn't support dark mode yet. Only public pages support dark theme

hariombalhara avatar Sep 18 '22 10:09 hariombalhara

I am not able to reproduce it as I am not able to set my theme to dark mode. I am discussing this issue in slack at the moment.

hussamkhatib avatar Sep 20 '22 18:09 hussamkhatib

@hariombalhara , I can reproduce this one my hand, is there any figma design?

gracebir avatar Sep 21 '22 09:09 gracebir

@gracebir you can find the figma file in readme

hussamkhatib avatar Sep 22 '22 16:09 hussamkhatib

@JeroenReumkens has this been taken care of? Let's move to 2.3 if not 🙏

ciaranha avatar Nov 19 '22 10:11 ciaranha

@Jaibles No actually it is not. I put most of the UI updates on hold until we have a single source of truth for a component. But since this applies to the public booking page as well, I'm actually picking this up right now, so at least the booking page looks neat 👌

JeroenReumkens avatar Nov 21 '22 08:11 JeroenReumkens