cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feature/create-account-view-3797

Open alannnc opened this issue 2 years ago • 2 comments

What does this PR do?

  • Creates new view for /auth/create-account

Missing

  • redirect to stripe for single premium payment
  • make sure it works for self hosted
  • ~~Passwords hints not displaying from component~~ (@leog)
  • Move api/signup code to app/web ( premium username logic its there)
  • ~~Google Login~~
  • SAML

Fixes #3797

Environment: Staging(main branch) / Production

Type of change

  • [X] New feature (non-breaking change which adds functionality)

How to test?

  • [ ] Test A
  • [ ] Test B

Checklist

  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works

alannnc avatar Sep 14 '22 02:09 alannnc

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Sep 17, 2022 at 8:18PM (UTC)

vercel[bot] avatar Sep 14 '22 02:09 vercel[bot]

Hey @alannnc. Please see #4509 as I brought up some UX from website. Didn't want to overwrite your changes here before your approval, as there may be requirements in terms of logic and UX that I could have missed.

leog avatar Sep 15 '22 22:09 leog

@Jaibles Do you think we're still missing this view? I think we were missing an image for self hosted but chat got lost in twist->threads transition maybe?

alannnc avatar Dec 20 '22 08:12 alannnc

Closing since a lot has changed we're probably better starting from scratch.

alannnc avatar Dec 20 '22 20:12 alannnc