cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Published 20 hours ago • verified publisher icon calcom

Fixing active vs existing apps in event type

Open leog opened this issue 2 years ago • 3 comments

What does this PR do?

Fixing active vs existing apps in event type Plus strange margin in overlay and App Card.

Fixes #4221

Environment: Staging(main branch) / Production

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Go to Event Type details page in v2 and see the correct number of active apps versus installed apps available in submenu. Also, when opening up Giphy dialog, a strange margin appeared in the AppCard and in the overlay, both fixed, see:

image

leog avatar Sep 12 '22 21:09 leog

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 25, 2022 at 2:14PM (UTC)

vercel[bot] avatar Sep 12 '22 21:09 vercel[bot]

@leog There are some conflicts in it now.

hariombalhara avatar Sep 14 '22 10:09 hariombalhara

@leog There are some conflicts in it now.

@hariombalhara Resolved.

leog avatar Sep 14 '22 15:09 leog

Let's focus on #4727

zomars avatar Sep 28 '22 11:09 zomars

Closing in favor of a more sustainable solution instead of a quick fix (initially intended for a hotfix BTW), see #4727.

leog avatar Sep 28 '22 16:09 leog