cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

/event-types/detail wrong empty screen for workflows

Open PeerRich opened this issue 3 years ago • 7 comments

  • [ ] border missing
  • [ ] button should be secondary
  • [ ] update and cancel buttons missing

https://user-images.githubusercontent.com/8019099/189080464-f3c2b8a2-cedb-4bfe-bd2c-bc72b035d1bf.mp4

PeerRich avatar Sep 08 '22 08:09 PeerRich

@PeerRich I actually believe them update/cancel buttons are meant to be deleted - I removed them way back when but it looks like they made their way back in with a merge along the lines

sean-brydon avatar Sep 08 '22 10:09 sean-brydon

Hi @PeerRich! How do i get to this page?

matheusmuniz03 avatar Sep 09 '22 17:09 matheusmuniz03

Hi @PeerRich! How do i get to this page?

you can opt-in to v2 at the bottom left

PeerRich avatar Sep 10 '22 09:09 PeerRich

Hi @matheusmuniz03 are you still interested in picking this up? If so could you let us know ASAP so we can pick this issue up if not - we would like to get this resolved for our V2 release

sean-brydon avatar Sep 12 '22 08:09 sean-brydon

HI @sean-brydon. Sorry for the delay, but I'm still interested, is it possible to continue this issue?

matheusmuniz03 avatar Sep 12 '22 14:09 matheusmuniz03

@PeerRich @sean-brydon Guys, I updated the project and my screen is like this (with the border and without the button). Do you want me to implement both buttons (Cancel and Update) or do you prefer to open another updated issue?

Captura de tela de 2022-09-12 14-09-48

matheusmuniz03 avatar Sep 12 '22 17:09 matheusmuniz03

Hey @PeerRich, I was trying to resolve this issue, but I noticed that the "cancel" and "update" buttons no longer exist in the "Apps" part. Is the implementation needed for "Workflows"? Loom Video: https://www.loom.com/share/ea94b07dafcd44ba8c0d782797f354a4

matheusmuniz03 avatar Sep 21 '22 13:09 matheusmuniz03

Hey @PeerRich, I was trying to resolve this issue, but I noticed that the "cancel" and "update" buttons no longer exist in the "Apps" part. Is the implementation needed for "Workflows"?

@matheusmuniz03 The update and cancel buttons are not needed in Workflows and Apps. But the border is still missing and the button should be secondary. I will update the issue

CarinaWolli avatar Sep 22 '22 20:09 CarinaWolli