cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Minimum booking notice should also allow hours and days

Open aspiers opened this issue 3 years ago • 5 comments

Is your proposal related to a problem?

The "Minimum booking notice" field can only be specified in minutes. This means that if I want a minimum notice period of hours or days, I need to multiply by 60 and maybe also by 24 in my head to get the right number of minutes:

image

Whilst as an ex-mathematician I enjoy little opportunities to keep my mental arithmetic sharp, this does not seem like ideal UI/UX design!

Describe the solution you'd like

Change the fixed mins text to a dropdown where the user can select between mins, hours, calendar days, and business days. Then the app will automatically calculate the corresponding number of minutes behind the scenes.

Alternatives

As a first step, don't implement the business days option, so the app can simply calculate a fixed number of minutes when the option is being configured, with very minimal code changes required.

Then add the business days option later, which would require slightly more complex logic to calculate the minimum notice period depending on the time of the week the booking was being made.

aspiers avatar Aug 25 '22 10:08 aspiers

It's worth noting that there is already an "opposite" setting, effectively of "maximum booking notice":

image

and this already offers a choice of time units between business days and calendar days. So a similar UI for the minimum booking notice seems to make sense.

aspiers avatar Aug 25 '22 10:08 aspiers

@PeerRich If this is something you would like to be fixed, I would love to work on it!

om-ray avatar Aug 25 '22 13:08 om-ray

@PeerRich If this is something you would like to be fixed, I would love to work on it!

yes please go ahead.❤️ thank you!

PeerRich avatar Aug 25 '22 20:08 PeerRich

@PeerRich Ill start on it asap!

om-ray avatar Aug 25 '22 20:08 om-ray

@om-ray Have you started working on this?

emrysal avatar Sep 19 '22 16:09 emrysal

@emrysal Hi! I'm sorry I didn't see this! I just recovered from the flu so progress has been slow, but yes I've been working on this.

om-ray avatar Sep 23 '22 15:09 om-ray

@aspiers @PeerRich @emrysal Please check out the PR I made for this issue

om-ray avatar Oct 26 '22 03:10 om-ray