cal.com
cal.com copied to clipboard
Location and team members will show on /book page
What does this PR do?
Meeting location and team members are now shown on the /book page. The meeting location will only show if the "display on booking page" box is checked when editing the location in the event type.
Fixes #3734
Environment: Staging(main branch) / Production
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
@om-ray is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
cal | ❌ Failed (Inspect) | Aug 25, 2022 at 10:28PM (UTC) | |
cal-com | ❌ Failed (Inspect) | Aug 25, 2022 at 10:28PM (UTC) | |
nightly-cal | ❌ Failed (Inspect) | Aug 25, 2022 at 10:28PM (UTC) |
1 Ignored Deployment
Name | Status | Preview | Updated |
---|---|---|---|
swagger | ⬜️ Ignored (Inspect) | Aug 25, 2022 at 10:28PM (UTC) |
@zomars I wasn't aware of that, I'll make the necessary changes and re-request! thank you for the review!
@PeerRich @zomars Could someone review this PR?
@zomars I wasn't aware of the handbook! Thank you for letting me know about it! I did the self-review and fixed all the lining warnings and errors I could find. Sorry about the repeated re-requests!
@om-ray are you able to fix up the type errors so we can get this reviewed?
@zlwaterfield Yes, although it's taking a bit longer because I've been traveling recently. I will push the fixes in a few hours!
@zomars let's close this out for now?
@zomars let's close this out for now?
Yup. Closing to focus on other PRs for now
@zomars Hey, I've been traveling every day so I didn't see this, I'll continue to work on this issue and will make a new PR after I make sure there are no errors! Thank you so much for spending so much time reviewing and giving me feedback. I'm still a beginner with open source projects so I'm sorry for any mistakes I make!