cal.com
cal.com copied to clipboard
Prevent saving error responses from Zoom to user credentials
What does this PR do?
The purpose of this PR is to prevent error responses from Zoom to be saved under a user's credentials. This would wipe out the refresh token which prevents a user from ever getting a valid token again.
In the future, I want to do an audit of our all our apps to make sure this isn't happening.
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
How should this be tested?
- Add Zoom to the account
- In the DB, find the zoom credential and delete a few characters from the refresh token and change the expiration date
- Try and create an event with Zoom as the location, you should receive an error but the credential's should still exist
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
cal | ❌ Failed (Inspect) | Sep 7, 2022 at 6:10PM (UTC) | |
cal-com | ❌ Failed (Inspect) | Sep 7, 2022 at 6:10PM (UTC) | |
nightly-cal | ❌ Failed (Inspect) | Sep 7, 2022 at 6:10PM (UTC) |
1 Ignored Deployment
Name | Status | Preview | Updated |
---|---|---|---|
swagger | ⬜️ Ignored (Inspect) | Sep 7, 2022 at 6:10PM (UTC) |
@joeauyeung @zomars should we get this merged?
@zlwaterfield @joeauyeung there's a type error to be fixed first:
@joeauyeung can you fix that type error?
Removed the union and added a fallback mechanism to remove malformed credentials. These shouldn't live in our DB.