add checkbox for send confirmation after event booking

[dezerb]

What does this PR do?

Add possibility to disable standard mail notification after event booking.

Fixes # (issue) https://github.com/calcom/cal.com/issues/3680

By default it is unchecked

Environment: Staging(main branch) / Production

Type of change

• [x] New feature (non-breaking change which adds functionality)

How should this be tested?

• [ ] Test A
• [ ] Test B

Checklist

[vercel[bot]]

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[PeerRich]

as I mentioned before, I think it would be better if it is negated and default false

"Don't send confirmation"

[PeerRich]

it's better to have no check box checked initially, if that makes sense?

[dezerb]

@PeerRich it's make perfect sense, I will make adjustment.

[dezerb]

updated https://www.loom.com/share/93b27bbfa00d45888e4de46675d823c0

[hariombalhara]

@dezerb Thanks for your contribution 🙏

This is the behaviour right now @PeerRich.

Once I select the option(which is by default unchecked)

• On a booking, no email is sent
• On cancellation, emails are sent as usual
• On rescheduling, no email is sent.
• On Request Reschedule, emails are sent as usual.

I am a little confused as to the usage of this option. What if the user wants to set up his own cancellation email? Do we give a separate checkbox then?

Also, because confirmation emails are important to be sent, it should somehow be made more clear to user(what if he checks this option and forgets to setup his own emails). Maybe we can integrate it with Workflows more seamlessly, automatically detecting that custom confirmation/cancellation emails are setup and then this option can be automatically checked or allowed to be checked.

[PeerRich]

@dezerb Thanks for your contribution 🙏

This is the behaviour right now @PeerRich.

Once I select the option(which is by default unchecked)

• On a booking, no email is sent
• On cancellation, emails are sent as usual
• On rescheduling, no email is sent.
• On Request Reschedule, emails are sent as usual.

I am a little confused as to the usage of this option. What if the user wants to set up his own cancellation email? Do we give a separate checkbox then?

Also, because confirmation emails are important to be sent, it should somehow be made more clear to user(what if he checks this option and forgets to setup his own emails). Maybe we can integrate it with Workflows more seamlessly, automatically detecting that custom confirmation/cancellation emails are setup and then this option can be automatically checked or allowed to be checked.

yeah, now that i think about it, i don't think you should be able to disable such core functionality.

i think a better alternative would be to customise the email which then overwrites the old confirmation mail

this feature has a lot of risks of unintended misbehavior

[CarinaWolli]

yeah, now that i think about it, i don't think you should be able to disable such core functionality.

i think a better alternative would be to customise the email which then overwrites the old confirmation mail

this feature has a lot of risks of unintended misbehavior

@PeerRich What about putting it into workflows? So once a user creates a workflow with the trigger 'when event is created' and the action 'Send email to ...' we show a checkbox that asks if the user wants to disable the standard confirmation email?

EDIT: Sorry @hariombalhara missed your comment. I agree it would make sense to integrate it into workflows 👍

[dezerb]

@hariombalhara @PeerRich @CarinaWolli in last iteration I introduced some new approach. While confirming the booking the backend will check if there is a suitable workflow and if so, it will skip the default notification. Thus, no new checkbox is required, assuming if someone has created a workflow, he does not need a standard confirmation. Please take a look and comment.

[hariombalhara]

I would leave it to @CarinaWolli to decide on the approach as she owns workflows.

[PeerRich]

I would leave it to @CarinaWolli to decide on the approach as she owns workflows.

I think its a good idea to have the checkbox in workflows to replace the default mail. that's where you would expect it

[dezerb]

@PeerRich ok I will take care about that and introduce the new checkbox. Should it be b default checked?

[PeerRich]

@PeerRich ok I will take care about that and introduce the new checkbox. Should it be b default checked?

default: off

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
cal-com	❌ Failed (Inspect)		Aug 10, 2022 at 1:57PM (UTC)
nightly-cal	❌ Failed (Inspect)		Aug 10, 2022 at 1:57PM (UTC)

[dezerb]

@PeerRich updated https://www.loom.com/share/75f63bf46b85438b8dccfd0a1b312a22

[CarinaWolli]

@Jaibles Can you take a look at this? https://www.loom.com/share/75f63bf46b85438b8dccfd0a1b312a22 I think the should adjust the text and design a little bit

[PeerRich]

closing for now, moving to 2.1