cal.com
cal.com copied to clipboard
Dynamic Links re-integrate with availability logic
What does this PR do?
Fixes #3409
Environment: Staging(main branch) / Production
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
How should this be tested?
- [ ] Test A
- [ ] Test B
Checklist
- I haven't read the contributing guide
- My code doesn't follow the style guidelines of this project
- I haven't performed a self-review of my own code and corrected any misspellings
- I haven't commented my code, particularly in hard-to-understand areas
- I haven't checked if my PR needs changes to the documentation
- I haven't checked if my changes generate no new warnings
- I haven't added tests that prove my fix is effective or that my feature works
- I haven't checked if new and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
cal | ❌ Failed (Inspect) | Aug 12, 2022 at 7:29PM (UTC) | |
cal-com | ❌ Failed (Inspect) | Aug 12, 2022 at 7:29PM (UTC) | |
nightly-cal | ❌ Failed (Inspect) | Aug 12, 2022 at 7:29PM (UTC) |
1 Ignored Deployment
Name | Status | Preview | Updated |
---|---|---|---|
swagger | ⬜️ Ignored (Inspect) | Aug 12, 2022 at 7:29PM (UTC) |
excited for this
@alishaz-polymath I think it would be a good idea to add jest tests for getSchedule
for dynamic logic. https://github.com/calcom/cal.com/blob/5165c511f5b060fff617f85ba2a6ca3d2042ae3c/apps/web/test/lib/getSchedule.test.ts
@alishaz-polymath I think it would be a good idea to add jest tests for
getSchedule
for dynamic logic. https://github.com/calcom/cal.com/blob/5165c511f5b060fff617f85ba2a6ca3d2042ae3c/apps/web/test/lib/getSchedule.test.ts
I agree. I have that planned as a follow up which speeds up the re-integration of dynamic links while allowing time for the edge-case availability issues to be resolved in the mean time.
Just minor comments, looking good 👍
All make sense. I had missed them out somehow, had put them in place to narrow-down the typesafety issues 😅 resolved them now 🙏