cal.com
cal.com copied to clipboard
Fix early return when expanding RRULE in CalDav/iCal
What does this PR do?
Recurring events in CalDav and iCal were only using the first instance of the event for availability checking. This fixes that issue.
(might fix) #3589 (I'm not sure if this is the same issue or not, it looks to be a bit subtler)
No visual changes
Environment: Fixed against main.
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
How should this be tested?
I looked for unit/integration tests but couldn't find any, so I might be missing some. To repro I created a new google calendar, accessed via CalDav. I created a single weekly recurring event in the calendar, and checked availability for each day in the month view for an event type in Cal.com. I could see that after my fix, the time slot with a clash was correctly not showing up in all 4 weeks, rather than just the first week.
Checklist
I did all those things, I really think this is a pretty simple fix. Feel free to disagree though! 😊
@willgittoes is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
cal | ❌ Failed (Inspect) | Aug 12, 2022 at 9:28PM (UTC) |
1 Ignored Deployment
Name | Status | Preview | Updated |
---|---|---|---|
swagger | ⬜️ Ignored (Inspect) | Aug 12, 2022 at 9:28PM (UTC) |
Thanks so much for accepting this! It was really easy to get the dev environment set up and working ☺