cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Caldav event is not updated on reschedule

Open TheCapsLock opened this issue 3 years ago • 7 comments
trafficstars

Found a bug? Please fill out the sections below. 👍

Issue Summary

When any attendee (or organizer) reschedules an event, the update is not replicated on caldav side

Steps to Reproduce

  1. Create a new schedule (I used optin ones)
  2. once booked, reschedule using the Web UI or link in the Email
  3. Event is correctly updated in Cal.com's Web UI but no on caldav side

Technical details

  • Firefox 100.0.2 ; cal.com v1.6.3 ; node v14.19.3
  • Caldav server : nextcloud 24.0.1

TheCapsLock avatar Jun 07 '22 07:06 TheCapsLock

Hi there. Thanks for reaching out. Our team will investigate.

milospuac avatar Jun 07 '22 07:06 milospuac

I just hit this issue too.

I tried to reschedule an event and got this error:

Could not reschedule the meeting. JSON.parse: unexpected end of data at line 1 column 1 of the JSON data

reschedule error

Also, in my case I ended up with two booking in cal.com (but only the un-reschdeuled original event on my Nextcloud CalDAV calendar)

jdaviescoates avatar Jun 08 '22 17:06 jdaviescoates

Hey, @milospuac ! I would like to work on this issue. Thanks!

noobyogi0010 avatar Jun 25 '22 18:06 noobyogi0010

Also, in my case I ended up with two booking in cal.com (but only the un-reschdeuled original event on my Nextcloud CalDAV calendar)

Just to add, I tried this a few more times and I no longer get an error, nor two events in my Cal.com bookings, but I end up two events in my Nextcloud calendar: the original booking, plus the rescheduled one.

I've created #3027 for this.

jdaviescoates avatar Jun 26 '22 14:06 jdaviescoates

@jdaviescoates I think any changes (reschedule or location update) results in an extra updated booking in the nextcloud calendar which is definitely unintended. We've identified potential causes and currently working on getting this sorted. Thanks for your patience 🙏

alishaz-polymath avatar Jul 28 '22 07:07 alishaz-polymath

@alishaz-polymath yeah, seems that way.

I have another similar issue too, but not sure if it warrants a new issue or not?

Bookings that are cancelled via the Cal.com web app are not deleted from my Nextcloud CalDAV calendar.

jdaviescoates avatar Aug 08 '22 10:08 jdaviescoates

Hey @jdaviescoates thanks for the update. I think there's a general fix we might merge in early this week which might end up fixing this ticket itself, or at least help us speed up the fix for this. As for the new issue you mentioned, please raise a new ticket and share 🙌

alishaz-polymath avatar Aug 08 '22 11:08 alishaz-polymath

Just tried this again, rescheduling still doesn't work and I still get this error:

Could not reschedule the meeting. JSON.parse: unexpected end of data at line 1 column 1 of the JSON data

But at least no duplicate event was created! (oh, actually it was, not in my Nextcloud calendar, but in my Cal.com booking there are now two identical events at different times)

jdaviescoates avatar Aug 24 '22 16:08 jdaviescoates

@jdaviescoates please book a slot with me Here and we'll have a go at it together as I couldn't re create it 🙏

alishaz-polymath avatar Aug 24 '22 16:08 alishaz-polymath

Fix merged earlier, somehow didn't auto close

alishaz-polymath avatar Oct 07 '22 21:10 alishaz-polymath

This is still exactly the same for me. Just tested again and got this:

Could not reschedule the meeting. JSON.parse: unexpected end of data at line 1 column 1 of the JSON data

jdaviescoates avatar Oct 19 '22 14:10 jdaviescoates

@jdaviescoates Accepted your call request. We'll have a go at it during our scheduled call 🙌

alishaz-polymath avatar Oct 19 '22 14:10 alishaz-polymath

Thanks. I just thought perhaps my browser/ Cal was getting confused by me testing bookings with myself all in the same browser window so just tried again without doing that. Still got an error, but a different one:

Could not reschedule the meeting. Unexpected end of JSON input

jdaviescoates avatar Oct 19 '22 14:10 jdaviescoates

@jdaviescoates Accepted your call request. We'll have a go at it during our scheduled call raised_hands

I'm in the call, are you joining @alishaz-polymath :) thanks!

jdaviescoates avatar Oct 24 '22 08:10 jdaviescoates

Hey @jdaviescoates, the fix is in review. You can keep track here Thanks for providing access to speed this up :)

alishaz-polymath avatar Oct 26 '22 07:10 alishaz-polymath

Great, thanks @alishaz-polymath, let us know when it's gone live on Cal.com so we can test it.

Presumably I can now delete your account on my system now? :)

jdaviescoates avatar Oct 26 '22 19:10 jdaviescoates

Hey @jdaviescoates It should be live on Monday/Tuesday. And I would keep the test account just in case you find any issues. 🙏 Please also note that currently when cancelling an event, the success message is provided before a feedback from the connected calendar is received and it generally takes some time for the event to be removed from the connected calendar. Please give it some time to remove from the connected calendar when testing cancellation (this should be anywhere between a few seconds to a few minutes) 😃

alishaz-polymath avatar Oct 27 '22 03:10 alishaz-polymath

It should be live on Monday/Tuesday.

It's Wednesday and I'm still having the same issue... hopefully that's just because the merge isn't live on Cal.com yet?

Edit: Actually, just tried it again and this time it did work! (I think perhaps it got confused before because I was using the same browser window... will re-test...)

jdaviescoates avatar Nov 02 '22 11:11 jdaviescoates

Hey @jdaviescoates it was merged yesterday so you definitely shouldn't be seeing that issue now. Could you please retest and maybe share a loom video? 🙏

alishaz-polymath avatar Nov 02 '22 11:11 alishaz-polymath

Worked when I tested again so I think it's all fine! Many thanks for your work on this!

jdaviescoates avatar Nov 02 '22 11:11 jdaviescoates

@jdaviescoates Amazing 😃 Thank you for the bug report. Please feel free to let me know if you face any other caldav related bugs at all 🙏

alishaz-polymath avatar Nov 02 '22 12:11 alishaz-polymath