cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Enabling Multiple Hosts for Robin Robin attendance

Open itsalam opened this issue 8 months ago • 7 comments

What does this PR do?

  • Added "multipleRRHosts" and "RRHostsPerMeeting" for eventType Record

  • Added switch + number input under Assignment Tab

  • Slightly modified layout in the assignmeng Tab

  • Fixes #11953 (GitHub issue number)

  • /claim #11953

Visual Demo (For contributors especially)

  • Undergoing, had issues effectively hosting this in organization mode, but a demo may work in non-org mode.

Video Demo (if applicable):

  • Undergoing, had issues effectively hosting this in organization mode, but a demo may work in non-org mode.

Image Demo (if applicable):

Before: image After: image

Videos:

  • Editing team event: https://www.loom.com/share/ad6fe56025314f2184f9b7189cbaee55?sid=f79ef553-ecb4-4a91-959c-383a507e6a30
  • Multiple bookings: https://www.loom.com/share/eff2e2605d9143c59d3f1f31ce3ddb8e?sid=1911d914-0032-497a-97ad-cf71d8d5f648

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set? None particuarily
  • What are the minimal test data to have? Access to a team, and the ability to book as a user outside of the team.
  • What is expected (happy path) to have (input and output)? RR hosts are evenly assigned, meaning that after a specific amount of rounds, every RR host has an equal amount of attendence.
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by mrge

Added support for assigning multiple Round Robin hosts per meeting, allowing more than one host to be selected and evenly distributed for each booking.

  • New Features
    • Added "Enable multiple Round Robin hosts" option and number input in the Assignment tab.
    • Updated backend and tests to support and balance multiple hosts per meeting.

itsalam avatar Apr 29 '25 11:04 itsalam

@itsalam is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 29 '25 12:04 vercel[bot]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "feat:Enabling Multiple Hosts for Robin Robin attendence". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-actions[bot] avatar Apr 29 '25 12:04 github-actions[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/29/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (04/29/25)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Apr 29 '25 12:04 graphite-app[bot]

type checks failing

retrogtx avatar May 01 '25 03:05 retrogtx

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar May 17 '25 00:05 github-actions[bot]

@retrogtx, made sure the checks are passsing, would you mind taking a look?

itsalam avatar May 21 '25 03:05 itsalam

@itsalam could you pls fix the merge conflicts?

kart1ka avatar Jun 16 '25 11:06 kart1ka

We decided not to add this feature to our product and closed the original issue. More details here: https://github.com/calcom/cal.com/issues/11953#issuecomment-2999531072

Thank you for your time and effort on this!

CarinaWolli avatar Jun 24 '25 09:06 CarinaWolli