cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Time format not respected

Open k3davis opened this issue 3 years ago • 15 comments
trafficstars

Found a bug? Please fill out the sections below. 👍

Issue Summary

In my profile I've selected "12 Hour" time format, by on my events it lists available slots in 24 Hour time format (13:00, etc.). I could not find a time format setting on the event setup itself, which is what led me to believe the profile setting controlled this. Perhaps there is another location I have missed?

Steps to Reproduce

  1. Set time format to 12 Hour in profile settings
  2. Expected to see time slots available for events in 12 Hour format, but did not

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Technical details

  • In case it is relevant, I experienced this issue on the hosted "app.cal.com" version (free saas version)

k3davis avatar Mar 07 '22 18:03 k3davis

Hello @k3davis thanks for your report.

We recently implemented some improvements on the 24/12h settings.

What is your browser locale? Would make sense that your browser's locale and profile settings don't match and thus the different views?

I'll look into this

agustif avatar Mar 07 '22 19:03 agustif

My browser local is en_US, so if the display is based on that it's even more odd to see 24h time by default. Thanks for looking into it!

k3davis avatar Mar 07 '22 23:03 k3davis

Hey, we recently merged an update to our timeFormat lib.

Can you please tell me if you're still experiencing this issue or has been solved for you @k3davis thank you!

agustif avatar Mar 24 '22 15:03 agustif

Doesn't appear to be any change so far.

image

k3davis avatar Mar 24 '22 22:03 k3davis

Doesn't appear to be any change so far.

image

Will check again and come back with news, sorry

agustif avatar Mar 31 '22 09:03 agustif

Issue still present in 1.6.0-h-FREE :(

k3davis avatar May 23 '22 12:05 k3davis

I found it had to do with localStorage.24hourformat. I was working on it on my desktop before leaving home so I'll try and finish it up next week.

joeauyeung avatar Jul 14 '22 19:07 joeauyeung

Also experiencing the exact same issue. Thanks for looking into fixing this!

mholt avatar Jul 18 '22 20:07 mholt

@joeauyeung will follow up this week

PeerRich avatar Jul 18 '22 21:07 PeerRich

I don't understand the issue on this one -- to this day on 2.0 "free" I have "12 hour" selected as time format here:

https://app.cal.com/settings/my-account/general

but the calendar still shows 24 hour time. In local browser storage timeOption.is24hClock is true. Even when I delete local storage, it is recreated as such. If I manually change the browser storage value, it looks correct, but who is going to do that? What am I missing here?

k3davis avatar Sep 16 '22 12:09 k3davis

@k3davis No, I'm seeing the same thing, definitely still doesn't appear to be fixed.

mholt avatar Sep 16 '22 14:09 mholt

@joeauyeung should we re-open this issue or should I put in another?

k3davis avatar Sep 16 '22 17:09 k3davis

Genuine kudos to the team working on this product for your frequent and numerous fixes and features, but man, if you could fix issue this I could actually use this product 🙃

I freely confess Americans (including myself) are lazy but I just don't see my visitors looking at something like 17:00 and intuitively knowing what they are signing up for, so they just won't. It's a blocker for me.

k3davis avatar Dec 02 '22 20:12 k3davis

your visitors should see this:

CleanShot 2022-12-03 at 15 53 44

the time format in your dashboard settings is only for you, not the public page

PeerRich avatar Dec 03 '22 14:12 PeerRich

Do you think it could be region-based? Coming from the US, for example, 24h is the default for all the booking pages, and that doesn't make sense for most people in the US.

mholt avatar Dec 03 '22 17:12 mholt

I have similar issue. On one of my devices by default in incognito window I see 12h , but I would like to see 24h. Calendly works ok on the same device, so I guess this is a bug in Cal.com

karolzlot avatar Jan 10 '23 11:01 karolzlot

there currently is a region check but its quite flaky.

happy to accept incoming PRs to improve it

PeerRich avatar Jan 10 '23 12:01 PeerRich