cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: added react-atom to embed generator and renamed others

Open Neon-20 opened this issue 9 months ago • 2 comments

What does this PR do?

  • Fixes #19679 (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

https://www.loom.com/share/c4f89ff0e2214c44aaf4980977b8524d?sid=357e371d-d1c8-4b87-b270-6a8e3611bffb

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Neon-20 avatar Mar 08 '25 11:03 Neon-20

@Neon-20 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 08 '25 11:03 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/08/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/08/25)

1 label was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (03/08/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (03/20/25)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Mar 08 '25 11:03 graphite-app[bot]

hey @Neon-20 there are some checks failing

retrogtx avatar Mar 20 '25 03:03 retrogtx

hey @Neon-20 there are some checks failing

@retrogtx Yeah they were failing because of : https://github.com/calcom/cal.com/issues/19863 Now they are working fine ig.

Neon-20 avatar Mar 20 '25 09:03 Neon-20

E2E results are ready!

github-actions[bot] avatar Mar 23 '25 11:03 github-actions[bot]

A test is failing plus the UI looks slightly diff from what is being asked

Looking into it.

Neon-20 avatar Mar 28 '25 11:03 Neon-20

hey @Neon-20 are you still working on this?

retrogtx avatar Apr 04 '25 02:04 retrogtx

I suppose you just need to change this in embed-code-generator-e2e.ts ->

await page.locator("[data-testid=horizontal-tab-react]").click(); to await page.locator("[data-testid=horizontal-tab-react-standard]").click();

I tried this out locally, but cannot push to your branch for some reason

retrogtx avatar Apr 04 '25 03:04 retrogtx

hey @Neon-20 thanks for your PR, looks like you are offline so will take this up here https://github.com/calcom/cal.com/issues/19679 wtih credit duly given! 🙏

retrogtx avatar Apr 09 '25 07:04 retrogtx