cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: added most cancelled bookings table inside insights page

Open Neon-20 opened this issue 9 months ago • 7 comments

What does this PR do?

Added most cancelled bookings table inside insights page

/claim #18657

  • Fixes #18657 (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change https://www.loom.com/share/a598dfc64a664a1088395bcd969a09bd?sid=86d4eb5e-f8af-4e47-9f76-fe9ac6b0abc9.

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

Neon-20 avatar Mar 03 '25 20:03 Neon-20

@Neon-20 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 03 '25 20:03 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/03/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/03/25)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Mar 03 '25 20:03 graphite-app[bot]

hey @Neon-20 we will need tests on this one

retrogtx avatar Mar 05 '25 16:03 retrogtx

hey @Neon-20 we will need tests on this one

Hey @retrogtx , can you let me know which tests should be added. Thanks !!

Neon-20 avatar Mar 05 '25 17:03 Neon-20

hey @Neon-20 we will need tests on this one

Hey @retrogtx , can you let me know which tests should be added. Thanks !!

anything that is related to logic will need a test here, you can surely skip writing tests for the changes in common.json, insights-view.tsx

retrogtx avatar Mar 05 '25 17:03 retrogtx

hey @Neon-20 we will need tests on this one

Hey @retrogtx , can you let me know which tests should be added. Thanks !!

anything that is related to logic will need a test here, you can surely skip writing tests for the changes in common.json, insights-view.tsx

@retrogtx In packages/features/insights/server/trpc-router.ts https://github.com/calcom/cal.com/blob/b8f07419231822386ddc188fefbf6ef72f9a23e9/packages/features/insights/server/trpc-router.ts#L757 membersWithMostBookings is an existing trpc function which doesn't have an existing e2e/integration/unit test. I have introduced a new function over there as membersWithMostCancellations. Could you clarify a bit on the test part of that , would be really helpful. Thanks !!

Neon-20 avatar Mar 05 '25 17:03 Neon-20

you will need to write tests for the new function that you have introduced!

retrogtx avatar Mar 06 '25 13:03 retrogtx

went ahead with https://github.com/calcom/cal.com/pull/19858

retrogtx avatar Apr 04 '25 06:04 retrogtx