feat: enable 'Overlay Calendar' enabled by default for signed in users

[sanchitttt]

What does this PR do?

• Fixes #18146(GitHub issue number)

Loom Video: https://www.loom.com/share/b67e6f4aa2ef4dcb9605cca4c28d74b9

Mandatory Tasks (DO NOT REMOVE)

• [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected).
• [ ] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

• For signed in user, simply see if "Overlay Calendar" is enabled by default
• For un-signed user, simply see if "Overlay Calendar" is disabled by default

[vercel[bot]]

@sanchitttt is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[graphite-app[bot]]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/14/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/06/25)

1 label was added to this PR based on Keith Williams's automation.

[sanchitttt]

Notes before merging

The behavior which is present currently is that:

1. 'Overlay Calendar' enabled on initial page load ✔️
2. 'Overlay Calendar' enabled on every view which is toggled ✔️

Clarification Needed

1. (Clarified below)

• ~~Should the 'Overlay Calendar' remain disabled if a user explicitly disables it?~~
  • ~~Option 1: Re-enable by default on every view toggle (current behavior).~~
  • ~~Option 2: Persist the user’s preference to keep it disabled, even after a view toggle.~~

2. For what is the packages\platform\atoms\booker\BookerPlatformWrapper.tsx file used?
   • Are the same changes required there too?

[sean-brydon]

• Option 2: Persist the user’s preference to keep it disabled, even after a view toggle.

I would probably say this if im honest. Maybe we dont need to go as far as adding to a DB but deffo storing in local storage/cookies would be great for this. I don't think its blocking for this PR can it can be implemented in a follow up if you don't manage to get round to this before it's merged

[github-actions[bot]]

This PR is being marked as stale due to inactivity.

[github-actions[bot]]

E2E results are ready!

• Workflow #55158.1 latest results

[github-actions[bot]]

This PR is being marked as stale due to inactivity.

[TusharBhatt1]

@sanchitttt you still working on it ?

[retrogtx]

@sanchitttt you still working on it ?

under progress

[retrogtx]

@anikdhabal should I make changes to this PR again 😆

[Ryukemeister]

in previous conversations @anikdhabal suggests the following change

@retrogtx The previous changes look good and simple. The only thing that needs to be added in the check is verifying if a supported calendar is connected or not.

just wanna know if that condition is already covered in previous PRs or do we not plan to check if the supported calendar is connected or not when toggle overlay calendar is true?

[retrogtx]

we do plan to check whether the calendar is connected or not