cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: correct line-breaks in calendar event description

Open michaelvalette opened this issue 1 year ago • 5 comments

What does this PR do?

Reviewing the function getRichDescription in CalEventParser and its sub-functions in the same file, in order to correct all those double/triple/quadruple line-breaks in the event descriptions. No functional change, just cleaning the UI.

BEFORE

393995966-eb981a69-8a84-468e-8876-ced85249911a

AFTER

Screenshot 2024-12-10 at 16 13 47 Screenshot 2024-12-10 at 16 14 07

Also adding explicit output types on all functions.

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

To reproduce:

  • Plug a calendar as organizer
  • Book as a client
  • Event should appear in calendar and shouldn't contain double/triple/quadruple line-breaks

Checklist

michaelvalette avatar Dec 09 '24 21:12 michaelvalette

@michaelvalette is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 09 '24 21:12 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 09 '24 21:12 CLAassistant

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/09/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/11/24)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Dec 09 '24 21:12 graphite-app[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
calcom-web-canary ❌ Failed (Inspect) Dec 10, 2024 3:17pm

vercel[bot] avatar Dec 10 '24 15:12 vercel[bot]

E2E results are ready!

github-actions[bot] avatar Dec 11 '24 08:12 github-actions[bot]

This seems to be causing #17928 We're seeing an influx of errors on the cron executing for reminders with more than 24k logs in the last 2 days:

Error scheduling Email with error TypeError: Cannot read properties of undefined (reading 'trim')

zomars avatar Dec 13 '24 19:12 zomars