fix: correct line-breaks in calendar event description
What does this PR do?
Reviewing the function getRichDescription in CalEventParser and its sub-functions in the same file, in order to correct all those double/triple/quadruple line-breaks in the event descriptions. No functional change, just cleaning the UI.
BEFORE
AFTER
Also adding explicit output types on all functions.
Mandatory Tasks (DO NOT REMOVE)
- [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
- [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
- [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.
How should this be tested?
To reproduce:
- Plug a calendar as organizer
- Book as a client
- Event should appear in calendar and shouldn't contain double/triple/quadruple line-breaks
Checklist
@michaelvalette is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
Graphite Automations
"Add consumer team as reviewer" took an action on this PR • (12/09/24)
1 reviewer was added to this PR based on Keith Williams's automation.
"Add community label" took an action on this PR • (12/09/24)
1 label was added to this PR based on Keith Williams's automation.
"Add ready-for-e2e label" took an action on this PR • (12/11/24)
1 label was added to this PR based on Keith Williams's automation.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| calcom-web-canary | ❌ Failed (Inspect) | Dec 10, 2024 3:17pm |
This seems to be causing #17928 We're seeing an influx of errors on the cron executing for reminders with more than 24k logs in the last 2 days:
Error scheduling Email with error TypeError: Cannot read properties of undefined (reading 'trim')