cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: show ooo forwarding and emoji when not available

Open kart1ka opened this issue 1 year ago • 4 comments

What does this PR do?

  • Fixes #17601 (GitHub issue number)
  • Fixes CAL-4704 (Linear issue number - should be visible at the bottom of the GitHub issue description)

https://github.com/user-attachments/assets/b4903a6d-2b91-4994-b7dd-8d8966abbd27

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Create a busy event on your calendar for a specific date.
  • Mark yourself as "Out of Office" (OOO) for the same date as the busy event.
  • Navigate to the booking page for an event.
  • Verify that the date is now marked as OOO, even though it is unavailable due to the busy event on the calendar.

kart1ka avatar Dec 07 '24 16:12 kart1ka

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 07 '24 16:12 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/07/24)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Dec 07 '24 16:12 graphite-app[bot]

E2E results are ready!

github-actions[bot] avatar Dec 09 '24 21:12 github-actions[bot]

@kart1ka e2e tests are failing, please fix it 🙏

@Praashh Those tests are failing on the main branch as well.

kart1ka avatar Dec 10 '24 02:12 kart1ka

LGTM!! but blocking it because of failure of test cases

Praashh avatar Jan 04 '25 15:01 Praashh

Hey @Praashh I have fixed the failing test. Please re-review.

kart1ka avatar Jan 15 '25 07:01 kart1ka

i dont yet understand yet waht this PR fixes. the video looks the same like the current behaviour @Praashh

PeerRich avatar Jan 21 '25 09:01 PeerRich

i dont yet understand yet waht this PR fixes. the video looks the same like the current behaviour @Praashh

Hi @PeerRich This PR adds the feature to always show ooo emoji and the button to redirect to team member (member1 in the video) even when the user (owner1 in the video) is not available at that time (10 dec in the video).

kart1ka avatar Jan 21 '25 10:01 kart1ka

Hi @kart1ka we've had to revert this pr as it broke some core logic. We've since added a test to cover this. Feel free to reopen this pr to fix with the new test cases.

emrysal avatar Feb 04 '25 11:02 emrysal