cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Support event level conflict checking

Open hariombalhara opened this issue 1 year ago • 4 comments

What does this PR do?

Fixes #10754

Mandatory Tasks (DO NOT REMOVE)

  • [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [ ] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

hariombalhara avatar Dec 07 '24 02:12 hariombalhara

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "wip" found in pull request title "wip: Update schema, get happy path working with event type settings". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-actions[bot] avatar Dec 07 '24 02:12 github-actions[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 7:08pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 7:08pm

vercel[bot] avatar Dec 07 '24 02:12 vercel[bot]

E2E results are ready!

github-actions[bot] avatar Dec 12 '24 07:12 github-actions[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (12/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Dec 13 '24 10:12 graphite-app[bot]

@calcom/platform we will need to test it with atoms

ThyMinimalDev avatar Dec 13 '24 11:12 ThyMinimalDev

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

socket-security[bot] avatar Dec 18 '24 06:12 socket-security[bot]

Fixed conflicts

zomars avatar Dec 18 '24 18:12 zomars

if tests are passing it's good to go for platform

ThyMinimalDev avatar Dec 19 '24 17:12 ThyMinimalDev