cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: add default reminder to google calendar

Open rajesh-jonnalagadda opened this issue 1 year ago β€’ 9 comments

What does this PR do?

  • Fixes #16651 (GitHub issue number)
  • Fixes CAL-16651 (Linear issue number - should be visible at the bottom of the GitHub issue description) /claim #16651

https://www.loom.com/share/003046ddc7ee4c3d8278c8a249361a32

Mandatory Tasks (DO NOT REMOVE)

  • [X] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [X] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [X] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

rajesh-jonnalagadda avatar Nov 18 '24 23:11 rajesh-jonnalagadda

@rajesh-jonnalagadda is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 18 '24 23:11 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR β€’ (11/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR β€’ (11/18/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR β€’ (11/20/24)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Nov 18 '24 23:11 graphite-app[bot]

E2E results are ready!

github-actions[bot] avatar Nov 21 '24 19:11 github-actions[bot]

@Praashh may I know the review status of this?

rajesh-jonnalagadda avatar Nov 26 '24 14:11 rajesh-jonnalagadda

Changes seems good to me, @anikdhabal will give a final review.

@anikdhabal can you please reivew

rajesh-jonnalagadda avatar Nov 26 '24 15:11 rajesh-jonnalagadda

@anikdhabal Do we need any modifications? I don't understand why it is converted to draft.

rajesh-jonnalagadda avatar Nov 28 '24 12:11 rajesh-jonnalagadda

@rajesh-jonnalagadda i will review it shortlyπŸ™

anikdhabal avatar Nov 29 '24 17:11 anikdhabal

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 8, 2024 1:32pm

vercel[bot] avatar Dec 08 '24 13:12 vercel[bot]

@anikdhabal can I get feedback? it has been pending for a while

rajesh-jonnalagadda avatar Dec 08 '24 13:12 rajesh-jonnalagadda

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Dec 26 '24 00:12 github-actions[bot]

@rajesh-jonnalagadda can you please resolve these conflicts πŸ™

Praashh avatar Dec 26 '24 12:12 Praashh

@rajesh-jonnalagadda can you please resolve these conflicts πŸ™

I'm currently focused on other priority tasks. Can it wait?(even if I resolve it. I need to test my changes due to new changes.)

rajesh-jonnalagadda avatar Dec 26 '24 17:12 rajesh-jonnalagadda

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jan 11 '25 00:01 github-actions[bot]