calcom
feat: refactor the pipedrive crm from revert to original pipedrive
What does this PR do?
- Fixes #16797
- Fixes CAL-1679 (Linear issue number - should be visible at the bottom of the GitHub issue description) /claim #16797
https://www.loom.com/share/6147b80f849d4afb8e4882b3d380a5f8
Mandatory Tasks (DO NOT REMOVE)
- [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
- [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
- [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.
How should this be tested?
- Are there environment variables that should be set?
- What are the minimal test data to have?
- What is expected (happy path) to have (input and output)?
- Any other important info that could help to test that PR
Checklist
- I haven't read the contributing guide
- My code doesn't follow the style guidelines of this project
- I haven't commented my code, particularly in hard-to-understand areas
- I haven't checked if my changes generate no new warnings
@rajesh-jonnalagadda is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Graphite Automations
"Add consumer team as reviewer" took an action on this PR • (11/15/24)
1 reviewer was added to this PR based on Keith Williams's automation.
"Add community label" took an action on this PR • (11/15/24)
1 label was added to this PR based on Keith Williams's automation.
"Add foundation team as reviewer" took an action on this PR • (11/16/24)
1 reviewer was added to this PR based on Keith Williams's automation.
![graphite-app[bot] avatar](https://avatars.githubusercontent.com/in/158384?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @rajesh-jonnalagadda , can you attach a loom for your solution?
Ack
@itsalam both pr seems redundant and mostly similar. Can we pick one pr and collaborate and split accordingly Cc: @Praashh what do you think?
@rajesh-jonnalagadda,
I’m mainly interested in the experience and having the work on my GitHub. I’m happy to collaborate in a way that aligns with that and supports both our goals. I'm not particuarily interested with the reward.
@itsalam both pr seems redundant and mostly similar. Can we pick one pr and collaborate and split accordingly Cc: @Praashh what do you think?
yea, will pick one PR and will close the another one after testing
Overall LGTM!! Please make those small changes so I can approve it.
updated the pr. did some refactoring and added the permissions
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
How to handle users who have already installed this app and used it?
@anikdhabal That's a good point.
We could consider displaying an upgrade popup for all users who have previously installed the app. Since we can't access refresh tokens and access tokens directly without user consent, this approach seems to be the most feasible solution.
what do you suggest?
How to handle users who have already installed this app and used it?
@anikdhabal That's a good point.
We could consider displaying an upgrade popup for all users who have previously installed the app. Since we can't access refresh tokens and access tokens directly without user consent, this approach seems to be the most feasible solution.
what do you suggest?
yeah seems a good way to do.
How to handle users who have already installed this app and used it?
@anikdhabal That's a good point. We could consider displaying an upgrade popup for all users who have previously installed the app. Since we can't access refresh tokens and access tokens directly without user consent, this approach seems to be the most feasible solution. what do you suggest?
yeah seems a good way to do.
@anikdhabal can i start implementing this?
Hey @rajesh-jonnalagadda, can you please attach a loom for a fix for a user who has already installed the app?
@Praashh Instead of a pop-up, we can display the upgrade option directly on the installed page. Please review the demo. https://www.loom.com/share/030835f78e014f0bad9eeefffaecdba5
it's not working for me for some reason, can you please check again @rajesh-jonnalagadda
ack
ack
sir SS is not showing anything, but checking 🙏
@Praashh may i know the review status of this.
Changes seems good to me, @anikdhabal will give a final review.
@Praashh may i know the review status of this.
Changes seems good to me, @anikdhabal will give a final review.
@anikdhabal can you please review
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cal | ⬜️ Ignored (Inspect) | Visit Preview | Dec 11, 2024 4:37pm | |
| calcom-web-canary | ⬜️ Ignored (Inspect) | Visit Preview | Dec 11, 2024 4:37pm |
@anikdhabal can I get feedback? it has been pending for a while
Unit Tests are failing, @rajesh-jonnalagadda can you please fix this 🙏
@Praashh Apologies, I'm currently in the middle of a hackathon and won't be able to address this right now. Thank you for your understanding!
@rajesh-jonnalagadda please feel free to re-open this, closing as its stale now.
@rajesh-jonnalagadda thanks for your work. But going with this one:- https://github.com/calcom/cal.com/pull/22492