cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Change 'add override' to 'save override'

Open Amit91848 opened this issue 1 year ago • 6 comments

What does this PR do?

  • Fixes #17424
  • Fixes CAL-4654

Screencast from 2024-11-01 20-54-22.webm

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

Amit91848 avatar Nov 01 '24 15:11 Amit91848

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 01 '24 15:11 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/01/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/01/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (11/04/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Nov 01 '24 15:11 graphite-app[bot]

E2E results are ready!

github-actions[bot] avatar Nov 06 '24 12:11 github-actions[bot]

all good but we should have locale in all languages for Save Override and Update Override. Screenshot 2024-11-20 at 3 13 25 AM

expected:

Screenshot 2024-11-20 at 10 55 25 AM

Wouldn't this be handled by replexica bot @Praashh ? Also I see you handled noop, thanks for that

Amit91848 avatar Nov 23 '24 14:11 Amit91848

alrighty, it's working now for all the langs, thank you @Amit91848 approving it.

Praashh avatar Nov 23 '24 15:11 Praashh

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Dec 09 '24 00:12 github-actions[bot]