cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: HitPay Payment App

Open MuhammadAimanSulaiman opened this issue 1 year ago • 19 comments

What does this PR do?

This PR is for HitPay payment app. We have developed HitPay Payment app that users can make payment for booking using HitPay Payment.

Loom Video: https://www.loom.com/share/80e85c97c74a4a5b9a6fc7fefe2e78aa?sid=2b191abc-15bc-4378-a129-f95fb8f8541e

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Before testing HitPay payments, you need to set up your HitPay sandbox account.

    1. If you haven’t already, create an account on HitPay.
    2. Ensure that you have the necessary payment methods activated in your HitPay account.
  • Are there environment variables that should be set? These 2 environment variables should be set. NEXT_PUBLIC_API_HITPAY_PRODUCTION='https://api.hit-pay.com' NEXT_PUBLIC_API_HITPAY_SANDBOX='https://api.sandbox.hit-pay.com'

  1. There is HitPay payment app on /apps and /apps/categories/payment.

  2. Install HitPay payment app on /apps/hitpay

    2024-10-19_10h34_47

  3. Enter API Key and Salt values under Account Information and click on Connect with HitPay on /apps/hitpay/setup page. You can get API keys from HitPay Dashboard >API Keys. If you check sandbox switch next to Account Information, you can enter the API key and Salt of HitPay sanbox and all the transactions on events with HitPay enabled will be handled over HitPay sandbox.

    2024-10-19_10h41_47

  4. Check if the API key and Salt are updatable on /apps/hitpay/setup page after changing any value. The values cannot be edited at hidden status.

  5. Install HitPay app on an event.

    2024-10-21_10h44_50

  6. Check if the HitPay payment is working correctly on a booking page and then if the transaction is on Transactions page on the HitPay dashboard.

    2024-10-21_10h54_24

MuhammadAimanSulaiman avatar Oct 21 '24 08:10 MuhammadAimanSulaiman

@MuhammadAimanSulaiman is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 21 '24 08:10 vercel[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: MuhammadAimanSulaiman
:x: kutsaniuk
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 21 '24 08:10 CLAassistant

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "HitPay Payment App". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-actions[bot] avatar Oct 21 '24 08:10 github-actions[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (10/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/21/24)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Oct 21 '24 08:10 graphite-app[bot]

Can you please also add a README just like this, including all the steps to retrieve the API key and salt for Hitpay? https://github.com/calcom/cal.com/blob/main/packages/app-store/webex/README.md

anikdhabal avatar Oct 21 '24 09:10 anikdhabal

Pls uncommit the lock file

anikdhabal avatar Oct 21 '24 09:10 anikdhabal

Hello @anikdhabal, How are you! I failed to merge the upstream main to my hitpay-app branch. so I created an issue. https://github.com/calcom/cal.com/issues/17232 Please take a look into it.
Thank you!

MuhammadAimanSulaiman avatar Oct 22 '24 03:10 MuhammadAimanSulaiman

Hey @MuhammadAimanSulaiman could you pls first addressed the comments i left

anikdhabal avatar Oct 22 '24 05:10 anikdhabal

Hello @anikdhabal. I've fixed all the issues and pushed it. Could you kindly review it?

MuhammadAimanSulaiman avatar Oct 23 '24 02:10 MuhammadAimanSulaiman

Hi @anikdhabal. I pushed the fix to the lock file and you had the maintainer access. Could you please review it?

MuhammadAimanSulaiman avatar Oct 24 '24 01:10 MuhammadAimanSulaiman

@MuhammadAimanSulaiman type check is failing

anikdhabal avatar Oct 24 '24 06:10 anikdhabal

Hi @anikdhabal I fixed the type check error. Could you kindly review it?

MuhammadAimanSulaiman avatar Oct 25 '24 02:10 MuhammadAimanSulaiman

Hello @anikdhabal Could you please review the PR and guide me on the next steps?

MuhammadAimanSulaiman avatar Oct 31 '24 16:10 MuhammadAimanSulaiman

E2E results are ready!

github-actions[bot] avatar Nov 13 '24 11:11 github-actions[bot]

Awesome! Thanks for the review @Praashh

spacemonkey92 avatar Dec 06 '24 03:12 spacemonkey92

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ❌ Failed (Inspect) Dec 10, 2024 0:02am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 0:02am

vercel[bot] avatar Dec 06 '24 22:12 vercel[bot]

Awesome! Thanks for the review @Praashh

You are welcome, it's really a great PR 🙏

Praashh avatar Dec 09 '24 15:12 Praashh

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

socket-security[bot] avatar Dec 13 '24 01:12 socket-security[bot]

Hello @Praashh I fixed the production build error. Can you kindly review and guide me on the next steps?

MuhammadAimanSulaiman avatar Jan 10 '25 08:01 MuhammadAimanSulaiman

Hello @Praashh I fixed the production build error. Can you kindly review and guide me on the next steps?

E2E is failing, please check

Praashh avatar Jan 10 '25 19:01 Praashh

Hello @Praashh I fixed the e2e error. Can you please review?

MuhammadAimanSulaiman avatar Jan 13 '25 05:01 MuhammadAimanSulaiman