cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Add last login to user table and display that in orgs members view

Open asadath1395 opened this issue 1 year ago • 6 comments

What does this PR do?

/claim #17153

  • Fixes #17153 Add last login to user table and display that in orgs members view
  • Fixes CAL-4540

image

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Login as an admin and navigate to /settings/teams/{TEAM_ID}/members, replace TEAM_ID with the id of any team you are part of

asadath1395 avatar Oct 18 '24 11:10 asadath1395

@asadath1395 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 18 '24 11:10 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/18/24)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Oct 18 '24 11:10 graphite-app[bot]

@PeerRich Let me know if i missed something from your issue description, thanks!

asadath1395 avatar Oct 18 '24 11:10 asadath1395

can you record a loom.com and/or add screenshots?

PeerRich avatar Oct 18 '24 11:10 PeerRich

@PeerRich Do we need it in both the org and team user tables, or only one?

anikdhabal avatar Oct 18 '24 12:10 anikdhabal

can you record a loom.com and/or add screenshots?

Added a screenshot in the description

asadath1395 avatar Oct 18 '24 12:10 asadath1395

@PeerRich I created a middleware in trpc layer which keeps track of users activity, it stores in-memory and then writes to the DB every 1 hour as configured now to reduce frequent db write load and it displays accurate time, ref: screenshot in description. Initially users will have N/A value but the value will be populated as and when users keep using the app. Can you check this and let me know of any modifications required. Thanks

asadath1395 avatar Oct 22 '24 14:10 asadath1395

Thanks @asadath1395 for your work. It fixed by this:- https://github.com/calcom/cal.com/pull/17261

anikdhabal avatar Oct 23 '24 05:10 anikdhabal

/tip 20 @asadath1395

Thank you for your contribution 🙏

zomars avatar Oct 23 '24 05:10 zomars

🎉🎈 @asadath1395 has been awarded $20! 🎈🎊

algora-pbc[bot] avatar Oct 23 '24 05:10 algora-pbc[bot]