cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: add Adyen Payment App

Open itsalam opened this issue 1 year ago • 4 comments

What does this PR do?

  • Fixes #16860 (GitHub issue number)
  • Lets users provide their credentials to process on cal.com.
  • Fixes CAL-16860

Loom videos

Important

It should be noted that Adyen requires an agent to confirm and approve the integration implementation before providing the live API keys.

I've assumed part of integration is to leave the onus of procuring the credentials/accounts to the user. However, while its not explicity required, we may need to contact an Adyen representative regardless.

Also, Adyen requires a reachable hostname to run a mock payment, so local development without tools like ngrok will not yield entire results.

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox. N/A
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Identical payment app tests are added for the playwright test suite. These include payment adjustments. These can be run via yarn test-e2e:app-store

  • Are there environment variables that should be set? For live environments, ADYEN_LIVE_ENVIRONMENT must be set to true.
  • What are the minimal test data to have? Asides from manual e2e testing and playwright tests without API calls, none.
  • What is expected (happy path) to have (input and output)? A given user can switch to their Adyen setup, where they can then specify their payments via their Adyen account.
  • Any other important info that could help to test that PR

Checklist

/claim #16860

itsalam avatar Oct 18 '24 09:10 itsalam

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 18 '24 09:10 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (10/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/18/24)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Oct 18 '24 09:10 graphite-app[bot]