calcom
fix: city names were not showing in the options.
What does this PR do?
While selecting timezones city options were not shown, this is being solved with this pr.
- Fixes #17067
- Fixes CAL-4503
Mandatory Tasks (DO NOT REMOVE)
- [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
- [x] (N/A) I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
- [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.
How should this be tested?
checkout any timezone drop down in the app, you should be getting options after searching for a city.
- Are there environment variables that should be set?NO
- What are the minimal test data to have?N/A
- What is expected (happy path) to have (input and output)? to see cities as options in timezones dropdowns
- Any other important info that could help to test that PR N/A
Images
@ShreyTanna29 is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Graphite Automations
"Add consumer team as reviewer" took an action on this PR • (10/11/24)
1 reviewer was added to this PR based on Keith Williams's automation.
"Add community label" took an action on this PR • (10/11/24)
1 label was added to this PR based on Keith Williams's automation.
"Add ready-for-e2e label" took an action on this PR • (10/14/24)
1 label was added to this PR based on Keith Williams's automation.
![graphite-app[bot] avatar](https://avatars.githubusercontent.com/in/158384?v=4 "Published by a pub.dev verified publisher"){kind=small}
hey @emrysal, may I know whats stopping this PR from getting merged, please let me know if any changes are required.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @ShreyTanna29 - looks like the same test is failing as last time (but I'm sure it should find "Braz")
Hi @ShreyTanna29 - looks like the same test is failing as last time (but I'm sure it should find "Braz")
Checking it.
@emrysal I dont know why but all tests are failing on my local enviroment even without making any changes, I also tried using github codespace but the issue continues, maybe there is an error with my system config, I think solution to the test "yarn e2e --shard=1/4" failing is to change its timeout from 60 seconds (60000 ms) to 90 seconds (90000 ms) , current is occuring because it may not be able to find and click on the element within 60 seconds, I haven't tested this solution due to above stated reason, Exact changes to be made are :
1.) go to apps/web/playwright/availiblity.e2e.ts 2.) got to line 183 where "await page.getByTestId("select-option-America/Sao_Paulo").click();" is written. 3.) change it to "await page.getByTestId("select-option-America/Sao_Paulo").click({ timeout: 90000 });"
@emrysal can you please check that is this solution working or not ?
hey @emrysal , I hope all issues of this PR are solved and is ready to merge but if this is not the case, I am happy to help, please let me know anything that can be improved in this PR.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected]
![socket-security[bot] avatar](https://avatars.githubusercontent.com/in/156372?v=4 "Published by a pub.dev verified publisher"){kind=small}