cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

chore: `/availability` - Remove Pages Router / Render App Router

Open hbjORbj opened this issue 1 year ago • 12 comments

What does this PR do?

  • Fixes CAL-4275
  • Remove /availability routes from Pages Router and render them from App router.

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Navigate to:
  1. /availability 2./availability/troubleshoot 3./availability/[schedule]

hbjORbj avatar Sep 06 '24 08:09 hbjORbj

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (09/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Sep 06 '24 08:09 graphite-app[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:01am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 4:01am

vercel[bot] avatar Sep 06 '24 09:09 vercel[bot]

E2E results are ready!

github-actions[bot] avatar Sep 06 '24 09:09 github-actions[bot]

@hbjORbj I see the note about "should not be merged until perf measures are done". Are you going to add that here?

keithwillcode avatar Sep 09 '24 13:09 keithwillcode

@hbjORbj I see the note about "should not be merged until perf measures are done". Are you going to add that here?

@keithwillcode Hey Keith, I will actually add it in #16536 as that PR must bring quite perf improvements. I will modify the description and title so this PR doesn't get merged incrementally.

hbjORbj avatar Sep 09 '24 14:09 hbjORbj

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[DO NOT MERGE YET] chore: [final phase of app router migration] Remove Pages Router / Render App Router - `/availability`". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-actions[bot] avatar Sep 09 '24 14:09 github-actions[bot]

DO NOT MERGE UNTIL EITHER (1) REVALIDATION LOGIC FOR SSR IS ADDED or (2) SSR IS REVERTED

hbjORbj avatar Sep 25 '24 15:09 hbjORbj

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Oct 10 '24 00:10 github-actions[bot]

Re-drafting due the [DO NOT MERGE YET] notice

zomars avatar Oct 15 '24 16:10 zomars

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Oct 31 '24 00:10 github-actions[bot]

@emrysal can you re-approve? :) I pushed a commit that adds availability routes to config.matcher in middleware

hbjORbj avatar Dec 13 '24 04:12 hbjORbj