cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

perf: Refactor bookings queries for API

Open keithwillcode opened this issue 1 year ago • 5 comments

What does this PR do?

Seeing that pulling bookings takes around 600ms on our prod db and it's because we use an 'OR' when looking for attendees. Splitting it out is much faster.

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] N/A I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Ensure all API automated tests pass and ensure that pulling data for bookings is not impacted

keithwillcode avatar Aug 29 '24 23:08 keithwillcode

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 6:22pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 7, 2025 6:22pm
cal ⬜️ Skipped (Inspect) May 7, 2025 6:22pm

vercel[bot] avatar Aug 29 '24 23:08 vercel[bot]

LGTM. Waiting on checks.

zomars avatar Aug 30 '24 00:08 zomars

Closing and reopening because the checks just stopped working for some reason

keithwillcode avatar Aug 30 '24 00:08 keithwillcode

E2E results are ready!

github-actions[bot] avatar Aug 30 '24 05:08 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Sep 30 '24 00:09 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Nov 03 '24 00:11 github-actions[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 06 '25 15:02 CLAassistant

Closing since this is stale, v1 is deprecated and Fluid Compute has made usage going way down. No need to introduce the risk here.

keithwillcode avatar Mar 11 '25 18:03 keithwillcode

The failing dev build was due to OOM issue on Vercel. Redeploying.

keithwillcode avatar May 07 '25 16:05 keithwillcode