cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

refactor: allow managed event tests parallel runs

Open zomars opened this issue 1 year ago • 4 comments

What does this PR do?

Refs #16099

Split managed event type tests to run in parallel instead on sequence. This should improve overall testing time. These tests seems to be borked in main as well. Here's an example of them timing out but still are marked as "passed"

Before:

image

After

image

What changed?

  • Added managedEventUnlockedFields parameter to the createTeamEventType function to allow specifying unlocked fields for managed events.
  • Updated createUsersFixture to include managedEventUnlockedFields parameter and logic to handle adding teammates to managed events.
  • Enhanced related e2e tests in managed-event-types.e2e.ts to validate functionality around managed events including locked/unlocked fields, organizer default apps, and tab renders.

How to test?

  1. Execute e2e tests in managed-event-types.e2e.ts to ensure that managed event type functionalities are correctly implemented.

Mandatory Tasks (DO NOT REMOVE)

  • [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [ ] I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

zomars avatar Aug 07 '24 06:08 zomars

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ❌ Failed (Inspect) Sep 6, 2024 5:14am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 5:14am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 5:14am

vercel[bot] avatar Aug 07 '24 06:08 vercel[bot]

  • #16113 Graphite 👈
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zomars and the rest of your teammates on Graphite Graphite

zomars avatar Aug 07 '24 06:08 zomars

E2E results are ready!

github-actions[bot] avatar Aug 13 '24 23:08 github-actions[bot]

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (08/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Aug 15 '24 20:08 graphite-app[bot]