cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: internal audit logger

Open TaduJR opened this issue 1 year ago β€’ 15 comments
trafficstars

What does this PR do?

This change tries to resolve #1461 by adding audit logger on v1 and v2 api and on nextjs backend. These are the list of events handled on Teams and Organizations

Event-Types
	- Modified
		Event Setup
			Title
			Duration
			Location
		Assignment
		        Scheduling Type
	- Created
	- Delete

Bookings
	- Modified
		Reschedule
		Edit Location
	- Created
	- Cancelled
  • Fixes #1461 (GitHub issue number)
  • Fixes CAL-1461 (Linear issue number - should be visible at the bottom of the GitHub issue description)

https://www.loom.com/share/db03dbc9794d489bafcdace4a1eee664

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • [ ] I have added a Docs issue here if this PR makes changes that would require a documentation change
  • [x] I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set? No
  • What are the minimal test data to have? Team/Organization and User Entity Records
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR?

Checklist

  • I haven't commented my code, particularly in hard-to-understand areas /claim #1461

TaduJR avatar Jul 28 '24 08:07 TaduJR

@TaduJR is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jul 28 '24 08:07 vercel[bot]

Hey there and thank you for opening this pull request! πŸ‘‹πŸΌ

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "internal audit logger". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-actions[bot] avatar Jul 28 '24 08:07 github-actions[bot]

Graphite Automations

"Add community label" took an action on this PR β€’ (07/28/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR β€’ (07/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR β€’ (07/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR β€’ (10/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Jul 28 '24 08:07 graphite-app[bot]

Moving to this PR for more cleaner approach from https://github.com/calcom/cal.com/pull/15948

TaduJR avatar Jul 28 '24 18:07 TaduJR

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Aug 15 '24 00:08 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Sep 06 '24 00:09 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Sep 30 '24 00:09 github-actions[bot]

@TaduJR really great work, could you pls fix the conflictsπŸ™

anikdhabal avatar Oct 04 '24 06:10 anikdhabal

Thank you @anikdhabal. I thought the team abandoned this issue. Ok, I will fix the conflicts.

TaduJR avatar Oct 04 '24 10:10 TaduJR

Thank you @anikdhabal. I thought the team abandoned this issue. Ok, I will fix the conflicts.

/tip 20

Thanks for the effort so far. We really appreciate it πŸ™πŸ½

zomars avatar Oct 04 '24 20:10 zomars

πŸŽ‰πŸŽˆ @TaduJR has been awarded $20! 🎈🎊

algora-pbc[bot] avatar Oct 04 '24 20:10 algora-pbc[bot]

Thank you @zomars. Working on the conflicts.

TaduJR avatar Oct 11 '24 05:10 TaduJR

Hello @zomars. I am sorry for not finishing it quickly. I was busy. I am working on the it right now to pass the tests. Sorry I should have converted it to draft.

TaduJR avatar Oct 15 '24 14:10 TaduJR

Hello @zomars. I am sorry for not finishing it quickly. I was busy. I am working on the it right now to pass the tests. Sorry I should have converted it to draft.

It's ok I'm just getting another round of review. Appreciate the patience πŸ™πŸ½

zomars avatar Oct 15 '24 14:10 zomars

I'm seeing that you're still working on this. Could you check the test. And while at it, could you add some video demos?

Hello @zomars. Fixed the PR to pass the test also checkout the loom.

TaduJR avatar Oct 18 '24 16:10 TaduJR