cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: issue #9523 limited scroll range on mobile device

Open stefanmuljadi opened this issue 1 year ago • 5 comments

What does this PR do?

As per the suggestion in #9523, overflow-y-auto and scroll-auto are removed to prevent having a double scroll wheel that causes the users to be unable to scroll through the page as expected unless they begin to click into the form and fill out payment info.

  • Fixes #9523

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • [ ] I have added a Docs issue here if this PR makes changes that would require a documentation change
  • [ ] I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

stefanmuljadi avatar Jun 20 '24 09:06 stefanmuljadi

@stefanmuljadi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 20 '24 09:06 vercel[bot]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fix/issue 9523". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-actions[bot] avatar Jun 20 '24 09:06 github-actions[bot]

Graphite Automations

"Add community label" took an action on this PR • (06/20/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (06/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Jun 20 '24 10:06 graphite-app[bot]

@stefanmuljadi it looks like you've pushed the changes for the yarn.lock file. We generally update the yarn.lock while updating or deleting packages and it doesn't seem like we're doing that here, can you revert the yarn.lock file changes?

Ryukemeister avatar Jun 23 '24 03:06 Ryukemeister

@stefanmuljadi Could you please record a before and after loom/video for both embedded and non-embedded booker

hariombalhara avatar Jun 25 '24 08:06 hariombalhara

As this is a small change but would need to be tested well. Requesting some screenshots to verify it works

@stefanmuljadi

anikdhabal avatar Jul 16 '24 15:07 anikdhabal

This PR is being closed due to staleness. Please reopen if work is to continue.

keithwillcode avatar Jul 29 '24 04:07 keithwillcode