cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: meeting link is not updated and broken ui in edit location dialog

Open anikdhabal opened this issue 1 year ago • 3 comments
trafficstars

What does this PR do?

  • Fixes #15497
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

before:- Screenshot 2024-06-20 091049

Now:- Screenshot 2024-06-20 090909

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • [ ] I have added a Docs issue here if this PR makes changes that would require a documentation change
  • [ ] I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

anikdhabal avatar Jun 20 '24 03:06 anikdhabal

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 20 '24 03:06 vercel[bot]

Graphite Automations

"Add community label" took an action on this PR • (06/20/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Jun 20 '24 03:06 graphite-app[bot]

What I also found is that if one changes location of booking to cal video:

Screenshot 2024-06-21 at 15 02 19

saves and refreshes page and checks location, its still the previous one: Screenshot 2024-06-21 at 15 02 33

supalarry avatar Jun 21 '24 13:06 supalarry

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jul 12 '24 00:07 github-actions[bot]

@anikdhabal any update on this PR?

Udit-takkar avatar Jul 12 '24 10:07 Udit-takkar

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jul 27 '24 00:07 github-actions[bot]

What I also found is that if one changes location of booking to cal video:

Actually, we faced this error in dev mode if the Cal video API key is null. In production, I’ve tested it and it works fine Thanks @supalarry for the reviews.

anikdhabal avatar Jul 27 '24 06:07 anikdhabal

Thank goodness this is finally fixed! Much appreciated.

RayBB avatar Jul 31 '24 19:07 RayBB

@Udit-takkar @PeerRich this PR shouldn't have been merged yet. Will revert. Unless I'm missing more context if we have a location that doesn't start with "https" It will wipe out all existing booking metadata.

image

zomars avatar Jul 31 '24 19:07 zomars