cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Add proton calendar

Open anikdhabal opened this issue 1 year ago • 4 comments

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • [x] N/A I have added a Docs issue here if this PR makes changes that would require a documentation change
  • [x] N/A I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

anikdhabal avatar Jun 19 '24 19:06 anikdhabal

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 19 '24 19:06 vercel[bot]

As of now, Proton Calendar does not have any public API, so in v1, let's make it dependent on Google Calendar. In v2, if we obtain the public API, then we can integrate it properly with OAuth.

anikdhabal avatar Jun 19 '24 19:06 anikdhabal

Graphite Automations

"Add community label" took an action on this PR • (06/19/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Jun 19 '24 19:06 graphite-app[bot]

As of now, Proton Calendar does not have any public API, so in v1, let's make it dependent on Google Calendar. In v2, if we obtain the public API, then we can integrate it properly with OAuth.

@emrysal @ThyMinimalDev what do you folks think about this approach for v1?

Ryukemeister avatar Jun 27 '24 07:06 Ryukemeister

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jul 12 '24 00:07 github-actions[bot]

not sure to understand the goal of this if Proton Calendar does not have any public API ?

ThyMinimalDev avatar Jul 22 '24 11:07 ThyMinimalDev

not sure to understand the goal of this if Proton Calendar does not have any public API ?

Hey most third-party calendars offer a “subscribe to calendar” feature that allows to enter the shared calendar’s URL. Subscribing to a calendar in this way syncs the calendar to shared Proton Mail calendar.

In Google Calendar (web app), for example, go to Settings → Add calendar → From URL. Paste the shared calendar’s URL into the From URL field and click Add calendar.

And as you can see this calendar also dependent to google calendar. We have calendar apps like: vimcal, ammie etc. that is similar to this

anikdhabal avatar Jul 22 '24 13:07 anikdhabal

Although this works from a Calendar POV, Proton Calendar users are all about privacy and data ownership. Having this calendar work through Google makes little sense in my opinion because Proton users will never agree to this.

IMO this is not the way to implement - let's wait until Proton has a native way of calendar integration such as CalDav or at least some way native to us so we don't have to rely on Google for these users.

emrysal avatar Jul 24 '24 17:07 emrysal

Although this works from a Calendar POV, Proton Calendar users are all about privacy and data ownership. Having this calendar work through Google makes little sense in my opinion because Proton users will never agree to this.

IMO this is not the way to implement - let's wait until Proton has a native way of calendar integration such as CalDav or at least some way native to us so we don't have to rely on Google for these users.

Yeah, this makes sense. Make this PR a draft until we have some implementation details

anikdhabal avatar Jul 24 '24 17:07 anikdhabal

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Aug 08 '24 00:08 github-actions[bot]

Since there is no definite timeline as to when things would progress, it's better to close this for now.

Amit91848 avatar Sep 07 '24 09:09 Amit91848