cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: wrong reschedule link for an org member for a booking on event outside the org

Open kart1ka opened this issue 1 year ago • 7 comments

What does this PR do?

  • Fixes #14832
  • Fixes CAL-3599 (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • [x] I have added a Docs issue here if this PR makes changes that would require a documentation change
  • [ ] I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Login as an acme org member
  • Book pro/30min
  • Go to /bookings page and find that booking
  • Try to reschedule
  • Correct reschedule link is shown

kart1ka avatar May 30 '24 11:05 kart1ka

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 30 '24 11:05 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar May 30 '24 11:05 github-actions[bot]

Graphite Automations

"Add community label" took an action on this PR • (05/30/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/30/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar May 30 '24 11:05 graphite-app[bot]

Hi @hariombalhara @Udit-takkar Just wanted to check in on the status of this PR. Could you please review this PR. If there are any changes I need to make, please let me know. Thanks!

kart1ka avatar Jun 04 '24 10:06 kart1ka

@kart1ka Thanks for the PR 🙏

Left a comment suggesting what could be done to fix the issue properly.

On it.

kart1ka avatar Jun 21 '24 06:06 kart1ka

Hi @hariombalhara I have made the changes as per the request. Please review and let me know if any other changes need to be made.

kart1ka avatar Jun 27 '24 08:06 kart1ka

We can't use WEBAPP_URL here

Screen.Recording.2024-06-13.at.1.56.20.PM.mov

Fixed.

kart1ka avatar Jun 27 '24 08:06 kart1ka

@hariombalhara I have made the changes as per the suggestion.

kart1ka avatar Jul 06 '24 07:07 kart1ka

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jul 31 '24 00:07 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Sep 04 '24 00:09 github-actions[bot]

E2E results are ready!

github-actions[bot] avatar Sep 11 '24 04:09 github-actions[bot]