cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: return 200 status code

Open Udit-takkar opened this issue 1 year ago • 5 comments

What does this PR do?

Not a bug but while testing recording locally app.cal.com/api/recorded-daily-video get triggered and as booking reference is not found in prod db it would return 404

https://github.com/calcom/cal.com/issues/15078#issuecomment-2120766674

Screenshot 2024-05-20 at 10 58 35 PM

Mandatory Tasks (DO NOT REMOVE)

  • [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • [ ] I have added a Docs issue here if this PR makes changes that would require a documentation change
  • [ ] I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

Udit-takkar avatar May 20 '24 17:05 Udit-takkar

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar May 20 '24 17:05 github-actions[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 7:05am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 7:05am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 7:05am

vercel[bot] avatar May 20 '24 17:05 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar May 20 '24 17:05 graphite-app[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 20 '24 17:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 321 Passing - ⚠️ 15 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/21/2024 07:16:55am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c865a20f404b65b26c92f440bab0537b70f63730

Started: 05/21/2024 07:13:34am UTC

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Change stripe presented currency Should be able to change currency
Retry 1Initial Attempt
0% (0) 0 / 197 runs
failed over last 7 days
0.51% (1) 1 / 197 run
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1Initial Attempt
0.45% (1) 1 / 223 run
failed over last 7 days
15.25% (34) 34 / 223 runs
flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests can select 'display on booking page' option when multiple organizer input type are present
Retry 1Initial Attempt
0.46% (1) 1 / 219 run
failed over last 7 days
5.48% (12) 12 / 219 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1Initial Attempt
0% (0) 0 / 213 runs
failed over last 7 days
65.26% (139) 139 / 213 runs
flaked over last 7 days
Namespacing Different namespaces can have different init configs
Retry 1Initial Attempt
0% (0) 0 / 212 runs
failed over last 7 days
63.21% (134) 134 / 212 runs
flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1Initial Attempt
0.47% (1) 1 / 213 run
failed over last 7 days
62.91% (134) 134 / 213 runs
flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1Initial Attempt
0% (0) 0 / 213 runs
failed over last 7 days
65.73% (140) 140 / 213 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0.47% (1) 1 / 212 run
failed over last 7 days
29.72% (63) 63 / 212 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
39.34% (96) 96 / 244 runs
failed over last 7 days
32.79% (80) 80 / 244 runs
flaked over last 7 days
Update Profile Can verify the newly added secondary email
Retry 1Initial Attempt
2.44% (6) 6 / 246 runs
failed over last 7 days
21.95% (54) 54 / 246 runs
flaked over last 7 days
Update Profile Can resend verification link if the secondary email is unverified
Retry 1Initial Attempt
11.38% (28) 28 / 246 runs
failed over last 7 days
31.30% (77) 77 / 246 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 2Retry 1Initial Attempt
9.73% (22) 22 / 226 runs
failed over last 7 days
24.78% (56) 56 / 226 runs
flaked over last 7 days
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1Initial Attempt
7.96% (18) 18 / 226 runs
failed over last 7 days
30.97% (70) 70 / 226 runs
flaked over last 7 days

📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1Initial Attempt
19.65% (45) 45 / 229 runs
failed over last 7 days
33.19% (76) 76 / 229 runs
flaked over last 7 days

📄   apps/web/playwright/organization/booking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Bookings Team Event Can create a booking for Round Robin EventType
Retry 1Initial Attempt
6.82% (15) 15 / 220 runs
failed over last 7 days
30.91% (68) 68 / 220 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar May 20 '24 17:05 deploysentinel[bot]