cal.com
cal.com copied to clipboard
refactor: v2 API event-types
What does this PR do?
- Fixes #XXXX (GitHub issue number)
- Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)
Mandatory Tasks (DO NOT REMOVE)
- [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected)
- [ ] I have added a Docs issue here if this PR makes changes that would require a documentation change
- [ ] I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)
How should this be tested?
- Are there environment variables that should be set?
- What are the minimal test data to have?
- What is expected (happy path) to have (input and output)?
- Any other important info that could help to test that PR
Checklist
- I haven't read the contributing guide
- My code doesn't follow the style guidelines of this project
- I haven't commented my code, particularly in hard-to-understand areas
- I haven't checked if my changes generate no new warnings
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ai | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 13, 2024 3:17pm |
2 Ignored Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cal | ⬜️ Ignored (Inspect) | Visit Preview | Jun 13, 2024 3:17pm | |
| calcom-web-canary | ⬜️ Ignored (Inspect) | Visit Preview | Jun 13, 2024 3:17pm |
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Eighty-two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/[user]/[type] |
412.1 KB |
640.69 KB | 183.05% (🟢 -0.27%) |
/[user]/[type]/embed |
412.11 KB |
640.69 KB | 183.05% (🟢 -0.27%) |
/apps |
279.16 KB |
507.75 KB | 145.07% (🟢 -0.55%) |
/apps/[slug] |
296.66 KB |
525.25 KB | 150.07% (🟢 -0.55%) |
/apps/[slug]/[...pages] |
587.64 KB |
816.22 KB | 233.21% (🟢 -0.57%) |
/apps/categories |
256.89 KB |
485.48 KB | 138.71% (🟢 -0.56%) |
/apps/categories/[category] |
261.24 KB |
489.82 KB | 139.95% (🟢 -0.55%) |
/apps/installed/[category] |
280.43 KB |
509.01 KB | 145.43% (🟢 -0.55%) |
/auth/platform/authorize |
87.24 KB |
315.82 KB | 90.23% (🟢 -0.26%) |
/availability |
427.88 KB |
656.47 KB | 187.56% (🟢 -0.56%) |
/availability/[schedule] |
411.63 KB |
640.21 KB | 182.92% (🟢 -0.56%) |
/bookings/[status] |
324.71 KB |
553.3 KB | 158.08% (🟢 -0.55%) |
/d/[link]/[slug] |
411.91 KB |
640.5 KB | 183.00% (🟢 -0.28%) |
/enterprise |
256.95 KB |
485.53 KB | 138.72% (🟢 -0.55%) |
/event-types |
556.63 KB |
785.21 KB | 224.35% (🟢 -0.57%) |
/event-types/[type] |
436.52 KB |
665.11 KB | 190.03% (🟢 -0.56%) |
/insights |
475.86 KB |
704.44 KB | 201.27% (🟢 -0.55%) |
/more |
256.46 KB |
485.04 KB | 138.58% (🟢 -0.55%) |
/org/[orgSlug]/[user]/[type] |
412.3 KB |
640.89 KB | 183.11% (🟢 -0.28%) |
/org/[orgSlug]/[user]/[type]/embed |
412.33 KB |
640.91 KB | 183.12% (🟢 -0.28%) |
/org/[orgSlug]/instant-meeting/team/[slug]/[type] |
411.93 KB |
640.51 KB | 183.00% (🟢 -0.27%) |
/org/[orgSlug]/team/[slug]/[type] |
412.13 KB |
640.71 KB | 183.06% (🟢 -0.28%) |
/settings/admin |
262.55 KB |
491.14 KB | 140.32% (🟢 -0.55%) |
/settings/admin/apps |
275.69 KB |
504.27 KB | 144.08% (🟢 -0.56%) |
/settings/admin/apps/[category] |
275.67 KB |
504.25 KB | 144.07% (🟢 -0.55%) |
/settings/admin/flags |
266.66 KB |
495.25 KB | 141.50% (🟢 -0.55%) |
/settings/admin/impersonation |
263.04 KB |
491.62 KB | 140.46% (🟢 -0.55%) |
/settings/admin/lockedSMS |
283.71 KB |
512.29 KB | 146.37% (🟢 -0.56%) |
/settings/admin/oAuth |
274.71 KB |
503.3 KB | 143.80% (🟢 -0.55%) |
/settings/admin/orgMigrations/_OrgMigrationLayout |
251.47 KB |
480.05 KB | 137.16% (🟢 -0.56%) |
/settings/admin/orgMigrations/moveTeamToOrg |
300.62 KB |
529.2 KB | 151.20% (🟢 -0.55%) |
/settings/admin/orgMigrations/moveUserToOrg |
320.03 KB |
548.61 KB | 156.75% (🟢 -0.57%) |
/settings/admin/orgMigrations/removeTeamFromOrg |
300.37 KB |
528.95 KB | 151.13% (🟢 -0.55%) |
/settings/admin/orgMigrations/removeUserFromOrg |
300.38 KB |
528.96 KB | 151.13% (🟢 -0.55%) |
/settings/admin/organizations |
264.12 KB |
492.7 KB | 140.77% (🟢 -0.55%) |
/settings/admin/organizations/[id]/edit |
262.94 KB |
491.52 KB | 140.43% (🟢 -0.55%) |
/settings/admin/users |
264.8 KB |
493.38 KB | 140.97% (🟢 -0.56%) |
/settings/admin/users/[id]/edit |
393.48 KB |
622.06 KB | 177.73% (🟢 -0.55%) |
/settings/admin/users/add |
393.21 KB |
621.79 KB | 177.65% (🟢 -0.55%) |
/settings/billing |
262.66 KB |
491.24 KB | 140.35% (🟢 -0.55%) |
/settings/developer/api-keys |
266.71 KB |
495.3 KB | 141.51% (🟢 -0.55%) |
/settings/developer/webhooks |
266.81 KB |
495.39 KB | 141.54% (🟢 -0.55%) |
/settings/developer/webhooks/[id] |
267.8 KB |
496.39 KB | 141.83% (🟢 -0.56%) |
/settings/developer/webhooks/new |
267.8 KB |
496.38 KB | 141.82% (🟢 -0.55%) |
/settings/my-account/appearance |
315.51 KB |
544.1 KB | 155.46% (🟢 -0.56%) |
/settings/my-account/calendars |
273.23 KB |
501.82 KB | 143.38% (🟢 -0.56%) |
/settings/my-account/conferencing |
274.5 KB |
503.09 KB | 143.74% (🟢 -0.55%) |
/settings/my-account/general |
378.43 KB |
607.02 KB | 173.43% (🟢 -0.55%) |
/settings/my-account/out-of-office |
267.33 KB |
495.92 KB | 141.69% (🟢 -0.55%) |
/settings/my-account/profile |
405.98 KB |
634.56 KB | 181.30% (🟢 -0.55%) |
/settings/organizations/admin-api |
262.56 KB |
491.14 KB | 140.33% (🟢 -0.56%) |
/settings/organizations/appearance |
286.61 KB |
515.2 KB | 147.20% (🟢 -0.56%) |
/settings/organizations/billing |
262.74 KB |
491.32 KB | 140.38% (🟢 -0.56%) |
/settings/organizations/dsync |
294.84 KB |
523.42 KB | 149.55% (🟢 -0.55%) |
/settings/organizations/general |
350.41 KB |
578.99 KB | 165.43% (🟢 -0.56%) |
/settings/organizations/members |
400.19 KB |
628.77 KB | 179.65% (🟢 -0.55%) |
/settings/organizations/privacy |
268.32 KB |
496.91 KB | 141.97% (🟢 -0.55%) |
/settings/organizations/profile |
398.73 KB |
627.31 KB | 179.23% (🟢 -0.55%) |
/settings/organizations/sso |
273.4 KB |
501.99 KB | 143.42% (🟢 -0.55%) |
/settings/organizations/teams/other |
263.31 KB |
491.89 KB | 140.54% (🟢 -0.55%) |
/settings/organizations/teams/other/[id]/appearance |
275.45 KB |
504.03 KB | 144.01% (🟢 -0.56%) |
/settings/organizations/teams/other/[id]/members |
270.4 KB |
498.98 KB | 142.57% (🟢 -0.56%) |
/settings/organizations/teams/other/[id]/profile |
469.54 KB |
698.13 KB | 199.46% (🟢 -0.55%) |
/settings/platform |
261.84 KB |
490.42 KB | 140.12% (🟢 -0.31%) |
/settings/platform/oauth-clients/[clientId]/edit |
260.45 KB |
489.03 KB | 139.72% (🟢 -0.33%) |
/settings/platform/oauth-clients/create |
259.74 KB |
488.32 KB | 139.52% (🟢 -0.29%) |
/settings/security/impersonation |
267.56 KB |
496.15 KB | 141.76% (🟢 -0.56%) |
/settings/security/password |
305.13 KB |
533.71 KB | 152.49% (🟢 -0.55%) |
/settings/security/sso |
272.73 KB |
501.31 KB | 143.23% (🟢 -0.55%) |
/settings/security/two-factor-auth |
270.99 KB |
499.57 KB | 142.74% (🟢 -0.56%) |
/settings/teams |
262.22 KB |
490.8 KB | 140.23% (🟢 -0.55%) |
/settings/teams/[id]/appearance |
275.43 KB |
504.02 KB | 144.01% (🟢 -0.56%) |
/settings/teams/[id]/billing |
262.74 KB |
491.32 KB | 140.38% (🟢 -0.56%) |
/settings/teams/[id]/members |
380.43 KB |
609.01 KB | 174.00% (🟢 -0.55%) |
/settings/teams/[id]/profile |
470.38 KB |
698.96 KB | 199.70% (🟢 -0.55%) |
/team/[slug]/[type] |
412.09 KB |
640.68 KB | 183.05% (🟢 -0.28%) |
/team/[slug]/[type]/embed |
412.12 KB |
640.71 KB | 183.06% (🟢 -0.28%) |
/teams |
256.68 KB |
485.27 KB | 138.65% (🟢 -0.56%) |
/upgrade |
256.81 KB |
485.39 KB | 138.68% (🟢 -0.55%) |
/video/[uid] |
295.84 KB |
524.42 KB | 149.83% (🟡 +1.37%) |
/workflows |
288.15 KB |
516.74 KB | 147.64% (🟢 -0.56%) |
/workflows/[workflow] |
410.57 KB |
639.15 KB | 182.62% (🟢 -0.71%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-
Current Playwright Test Results Summary
✅ 313 Passing - ❌ 3 Failing - ⚠️ 10 Flaky
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 05/17/2024 05:23:02pm UTC)
Run Details
Running Workflow PR Update on Github Actions
Commit: 5821ee014222772d5eeb7d178bef54daef815e82
Started: 05/17/2024 05:16:14pm UTC
❌ Failures
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Failure
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt Error: Test timeout of 60000ms exceeded.
|
3.51% (8)8 / 228 runsfailed over last 7 days |
14.91% (34)34 / 228 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Failure
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 2 • Retry 1 • Initial Attempt Error: Test timeout of 60000ms exceeded.
|
4.13% (10)10 / 242 runsfailed over last 7 days |
19.01% (46)46 / 242 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Failure
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2 • Retry 1 • Initial Attempt Error: Test timeout of 60000ms exceeded.
|
3.16% (8)8 / 253 runsfailed over last 7 days |
18.58% (47)47 / 253 runsflaked over last 7 days |
⚠️ Flakes
📄 apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
3.08% (7)7 / 227 runsfailed over last 7 days |
17.18% (39)39 / 227 runsflaked over last 7 days |
|
Stripe integration Paid booking should be able to be cancelled
Retry 1 • Initial Attempt |
2.25% (5)5 / 222 runsfailed over last 7 days |
13.06% (29)29 / 222 runsflaked over last 7 days |
📄 apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1 • Initial Attempt |
0.41% (1)1 / 242 runfailed over last 7 days |
47.52% (115)115 / 242 runsflaked over last 7 days |
📄 apps/web/playwright/manage-booking-questions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Manage Booking Questions For User EventType Do a booking with a Address type question and verify a few thing in b/w
Retry 1 • Initial Attempt |
2.50% (6)6 / 240 runsfailed over last 7 days |
1.67% (4)4 / 240 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- legacy login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0% (0)0 / 240 runsfailed over last 7 days |
18.75% (45)45 / 240 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user can add multiple organizer address
Retry 1 • Initial Attempt |
1.62% (4)4 / 247 runsfailed over last 7 days |
21.05% (52)52 / 247 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can resend verification link if the secondary email is unverified
Retry 1 • Initial Attempt |
12.64% (35)35 / 277 runsfailed over last 7 days |
29.96% (83)83 / 277 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.83% (2)2 / 240 runsfailed over last 7 days |
32.50% (78)78 / 240 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load if correct embedLibUrl is provided
Retry 1 • Initial Attempt |
0% (0)0 / 233 runsfailed over last 7 days |
32.62% (76)76 / 233 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
15.04% (37)37 / 246 runsfailed over last 7 days |
36.18% (89)89 / 246 runsflaked over last 7 days |
closing because will be handled in #15457