fix: meeting url should be available only when its confirmed
What does this PR do?
- Fixes #11857
Mandatory Tasks (DO NOT REMOVE)
- [x] I have self-reviewed the code (A decent size PR without self-review might be rejected)
- [ ] I have added a Docs issue here if this PR makes changes that would require a documentation change
- [ ] I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)
How should this be tested?
- Are there environment variables that should be set?
- What are the minimal test data to have?
- What is expected (happy path) to have (input and output)?
- Any other important info that could help to test that PR
Checklist
- I haven't read the contributing guide
- My code doesn't follow the style guidelines of this project
- I haven't commented my code, particularly in hard-to-understand areas
- I haven't checked if my changes generate no new warnings
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
Graphite Automations
"Add community label" took an action on this PR • (05/14/24)
1 label was added to this PR based on Keith Williams's automation.
"Add consumer team as reviewer" took an action on this PR • (05/14/24)
1 reviewer was added to this PR based on Keith Williams's automation.
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
https://github.com/calcom/cal.com/issues/11857#issuecomment-2137287427
I feel like we need to think this through
https://github.com/calcom/cal.com/issues/11857#issuecomment-2208106517
@SomayChauhan can't reproduce, I've set cal video as location.
https://github.com/user-attachments/assets/1430d171-a17d-419b-bd61-321bb9e4e77b
Can you recheck it?
hmm, that's weird 🤔 https://www.loom.com/share/69e221f1b5d74a4180c0ff9a02f4e220?sid=7d6e5712-5cb4-447f-ae1e-4b54b89f6c04 I can still see it
hmm, that's weird 🤔 https://www.loom.com/share/69e221f1b5d74a4180c0ff9a02f4e220?sid=7d6e5712-5cb4-447f-ae1e-4b54b89f6c04 I can still see it
Really weird, let me recheck it 🤔
@SomayChauhan fixed that. Pls check it once
@anikdhabal some e2e tests are failing, could you take a look
@anikdhabal some e2e tests are failing, could you take a look
Yeah, one e2e test is failing. I will fix that.
This PR is being marked as stale due to inactivity.
@anikdhabal is working on it. So, moved it to draft
Closing as stale for now :)