cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: meeting url should be available only when its confirmed

Open anikdhabal opened this issue 1 year ago • 16 comments

What does this PR do?

  • Fixes #11857

Screenshot 2024-05-14 054556 Screenshot 2024-05-14 054541

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • [ ] I have added a Docs issue here if this PR makes changes that would require a documentation change
  • [ ] I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

anikdhabal avatar May 14 '24 00:05 anikdhabal

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 14 '24 00:05 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar May 14 '24 00:05 github-actions[bot]

Graphite Automations

"Add community label" took an action on this PR • (05/14/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar May 14 '24 01:05 graphite-app[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 14 '24 01:05 github-actions[bot]

https://github.com/calcom/cal.com/issues/11857#issuecomment-2137287427

I feel like we need to think this through

ibex088 avatar Jun 22 '24 03:06 ibex088

#11857 (comment)

I feel like we need to think this through

Thanks for the suggestion @SomayChauhan

anikdhabal avatar Jun 24 '24 05:06 anikdhabal

https://github.com/calcom/cal.com/issues/11857#issuecomment-2208106517

hariombalhara avatar Jul 04 '24 04:07 hariombalhara

@SomayChauhan can't reproduce, I've set cal video as location.

https://github.com/user-attachments/assets/1430d171-a17d-419b-bd61-321bb9e4e77b

Can you recheck it?

anikdhabal avatar Jul 23 '24 17:07 anikdhabal

hmm, that's weird 🤔 https://www.loom.com/share/69e221f1b5d74a4180c0ff9a02f4e220?sid=7d6e5712-5cb4-447f-ae1e-4b54b89f6c04 I can still see it

ibex088 avatar Jul 24 '24 13:07 ibex088

hmm, that's weird 🤔 https://www.loom.com/share/69e221f1b5d74a4180c0ff9a02f4e220?sid=7d6e5712-5cb4-447f-ae1e-4b54b89f6c04 I can still see it

Really weird, let me recheck it 🤔

anikdhabal avatar Jul 24 '24 13:07 anikdhabal

@SomayChauhan fixed that. Pls check it once

anikdhabal avatar Jul 25 '24 15:07 anikdhabal

@anikdhabal some e2e tests are failing, could you take a look

ibex088 avatar Jul 26 '24 05:07 ibex088

@anikdhabal some e2e tests are failing, could you take a look

Yeah, one e2e test is failing. I will fix that.

anikdhabal avatar Jul 26 '24 05:07 anikdhabal

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Aug 22 '24 00:08 github-actions[bot]

E2E results are ready!

github-actions[bot] avatar Aug 24 '24 10:08 github-actions[bot]

@anikdhabal is working on it. So, moved it to draft

hariombalhara avatar Sep 19 '24 09:09 hariombalhara

Closing as stale for now :)

emrysal avatar Mar 10 '25 00:03 emrysal