cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

chore: Introduce a new class WebAppURL that extends URL

Open anikdhabal opened this issue 3 months ago • 4 comments

What does this PR do?

  • Fixes #14981

Mandatory Tasks (DO NOT REMOVE)

  • [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • [ ] I have added a Docs issue here if this PR makes changes that would require a documentation change
  • [ ] I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

anikdhabal avatar May 10 '24 23:05 anikdhabal

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 10 '24 23:05 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar May 10 '24 23:05 github-actions[bot]

Graphite Automations

"Add community label" took an action on this PR • (05/10/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar May 10 '24 23:05 graphite-app[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 10 '24 23:05 github-actions[bot]

Great work! Should other references of WEBAPP_URL also be refactored in this PR itself or a separate one?

utkershrajvenshi avatar May 11 '24 08:05 utkershrajvenshi

Great work! Should other references of WEBAPP_URL also be refactored in this PR itself or a separate one?

No, will handle it in this Pr.

anikdhabal avatar May 11 '24 08:05 anikdhabal