cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: use tokens for public mutating endpoints

Open anikdhabal opened this issue 1 year ago • 9 comments

What does this PR do?

  • Fixes #14342

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • [x] N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change
  • [x] N/A - I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

anikdhabal avatar May 08 '24 15:05 anikdhabal

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 08 '24 15:05 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar May 08 '24 15:05 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eighty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 411.48 KB 640.02 KB 182.86% (🟢 -0.17%)
/[user]/[type]/embed 411.48 KB 640.03 KB 182.86% (🟢 -0.17%)
/apps 277.46 KB 506 KB 144.57% (🟢 -0.35%)
/apps/[slug] 294.96 KB 523.5 KB 149.57% (🟢 -0.35%)
/apps/[slug]/[...pages] 585.62 KB 814.17 KB 232.62% (🟢 -0.38%)
/apps/categories 255.21 KB 483.75 KB 138.22% (🟢 -0.35%)
/apps/categories/[category] 259.53 KB 488.08 KB 139.45% (🟢 -0.35%)
/apps/installed/[category] 278.71 KB 507.25 KB 144.93% (🟢 -0.35%)
/availability 463.33 KB 691.87 KB 197.68% (🟢 -0.40%)
/availability/[schedule] 409.69 KB 638.23 KB 182.35% (🟢 -0.41%)
/booking/[uid] 364.86 KB 593.41 KB 169.54% (🔴 +39.63%)
/booking/[uid]/embed 364.87 KB 593.41 KB 169.55% (🔴 +39.62%)
/bookings/[status] 322.96 KB 551.5 KB 157.57% (🟢 -0.36%)
/d/[link]/[slug] 411.29 KB 639.83 KB 182.81% (🟢 -0.17%)
/enterprise 255.27 KB 483.81 KB 138.23% (🟢 -0.34%)
/event-types 554.89 KB 783.43 KB 223.84% (🟢 -0.38%)
/event-types/[type] 434.29 KB 662.84 KB 189.38% (🟢 -0.38%)
/insights 474.17 KB 702.71 KB 200.78% (🟢 -0.35%)
/more 254.78 KB 483.32 KB 138.09% (🟢 -0.34%)
/org/[orgSlug]/[user]/[type] 411.68 KB 640.22 KB 182.92% (🟢 -0.17%)
/org/[orgSlug]/[user]/[type]/embed 411.7 KB 640.25 KB 182.93% (🟢 -0.18%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 411.31 KB 639.85 KB 182.81% (🟢 -0.17%)
/org/[orgSlug]/team/[slug]/[type] 411.5 KB 640.04 KB 182.87% (🟢 -0.17%)
/payment/[uid] 119.16 KB 347.7 KB 99.34% (🟢 -0.15%)
/settings/admin 260.86 KB 489.4 KB 139.83% (🟢 -0.35%)
/settings/admin/apps 273.94 KB 502.49 KB 143.57% (🟢 -0.36%)
/settings/admin/apps/[category] 273.92 KB 502.47 KB 143.56% (🟢 -0.36%)
/settings/admin/flags 264.97 KB 493.51 KB 141.00% (🟢 -0.35%)
/settings/admin/impersonation 261.22 KB 489.76 KB 139.93% (🟢 -0.38%)
/settings/admin/lockedSMS 281.92 KB 510.46 KB 145.85% (🟢 -0.38%)
/settings/admin/oAuth 273.02 KB 501.56 KB 143.30% (🟢 -0.35%)
/settings/admin/orgMigrations/_OrgMigrationLayout 249.23 KB 477.77 KB 136.51% (🟢 -0.39%)
/settings/admin/orgMigrations/moveTeamToOrg 298.87 KB 527.41 KB 150.69% (🟢 -0.37%)
/settings/admin/orgMigrations/moveUserToOrg 318.18 KB 546.72 KB 156.21% (🟢 -0.39%)
/settings/admin/orgMigrations/removeTeamFromOrg 298.61 KB 527.15 KB 150.62% (🟢 -0.37%)
/settings/admin/orgMigrations/removeUserFromOrg 298.63 KB 527.17 KB 150.62% (🟢 -0.36%)
/settings/admin/organizations 262.42 KB 490.97 KB 140.28% (🟢 -0.35%)
/settings/admin/organizations/[id]/edit 261.24 KB 489.78 KB 139.94% (🟢 -0.35%)
/settings/admin/users 263.1 KB 491.64 KB 140.47% (🟢 -0.35%)
/settings/admin/users/[id]/edit 391.73 KB 620.27 KB 177.22% (🟢 -0.36%)
/settings/admin/users/add 391.46 KB 620 KB 177.14% (🟢 -0.36%)
/settings/billing 260.96 KB 489.51 KB 139.86% (🟢 -0.35%)
/settings/developer/api-keys 265.02 KB 493.56 KB 141.02% (🟢 -0.35%)
/settings/developer/webhooks 265.09 KB 493.64 KB 141.04% (🟢 -0.35%)
/settings/developer/webhooks/[id] 266.11 KB 494.65 KB 141.33% (🟢 -0.35%)
/settings/developer/webhooks/new 266.1 KB 494.65 KB 141.33% (🟢 -0.35%)
/settings/my-account/appearance 313.76 KB 542.3 KB 154.94% (🟢 -0.36%)
/settings/my-account/calendars 271.51 KB 500.05 KB 142.87% (🟢 -0.36%)
/settings/my-account/conferencing 272.77 KB 501.31 KB 143.23% (🟢 -0.36%)
/settings/my-account/general 376.74 KB 605.28 KB 172.94% (🟢 -0.35%)
/settings/my-account/out-of-office 265.64 KB 494.18 KB 141.19% (🟢 -0.34%)
/settings/my-account/profile 404.26 KB 632.8 KB 180.80% (🟢 -0.35%)
/settings/organizations/appearance 284.92 KB 513.46 KB 146.70% (🟢 -0.34%)
/settings/organizations/billing 261.04 KB 489.58 KB 139.88% (🟢 -0.35%)
/settings/organizations/dsync 330.26 KB 558.81 KB 159.66% (🟢 -0.35%)
/settings/organizations/general 348.55 KB 577.09 KB 164.88% (🟢 -0.39%)
/settings/organizations/members 429.36 KB 657.9 KB 187.97% (🟢 -0.34%)
/settings/organizations/platform/oauth-clients 263.53 KB 492.07 KB 140.59% (🟢 -0.35%)
/settings/organizations/platform/oauth-clients/create 263.71 KB 492.25 KB 140.64% (🟢 -0.35%)
/settings/organizations/privacy 266.63 KB 495.17 KB 141.48% (🟢 -0.35%)
/settings/organizations/profile 397.03 KB 625.57 KB 178.74% (🟢 -0.35%)
/settings/organizations/sso 271.71 KB 500.25 KB 142.93% (🟢 -0.35%)
/settings/organizations/teams/other 261.61 KB 490.15 KB 140.04% (🟢 -0.34%)
/settings/organizations/teams/other/[id]/appearance 273.75 KB 502.3 KB 143.51% (🟢 -0.34%)
/settings/organizations/teams/other/[id]/members 268.7 KB 497.25 KB 142.07% (🟢 -0.35%)
/settings/organizations/teams/other/[id]/profile 467.44 KB 695.98 KB 198.85% (🟢 -0.34%)
/settings/security/impersonation 265.87 KB 494.41 KB 141.26% (🟢 -0.35%)
/settings/security/password 303.37 KB 531.91 KB 151.98% (🟢 -0.37%)
/settings/security/sso 271.03 KB 499.58 KB 142.74% (🟢 -0.35%)
/settings/security/two-factor-auth 269.29 KB 497.83 KB 142.24% (🟢 -0.35%)
/settings/teams 260.53 KB 489.07 KB 139.73% (🟢 -0.34%)
/settings/teams/[id]/appearance 273.74 KB 502.28 KB 143.51% (🟢 -0.35%)
/settings/teams/[id]/billing 261.04 KB 489.58 KB 139.88% (🟢 -0.35%)
/settings/teams/[id]/members 378.62 KB 607.16 KB 173.47% (🟢 -0.38%)
/settings/teams/[id]/profile 468.27 KB 696.81 KB 199.09% (🟢 -0.35%)
/team/[slug]/[type] 411.47 KB 640.01 KB 182.86% (🟢 -0.17%)
/team/[slug]/[type]/embed 411.5 KB 640.04 KB 182.87% (🟢 -0.17%)
/teams 255 KB 483.54 KB 138.16% (🟢 -0.35%)
/upgrade 255.12 KB 483.67 KB 138.19% (🟢 -0.34%)
/workflows 286.38 KB 514.92 KB 147.12% (🟢 -0.37%)
/workflows/[workflow] 408.73 KB 637.27 KB 182.08% (🟢 -0.39%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 08 '24 15:05 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar May 30 '24 00:05 github-actions[bot]

Graphite Automations

"Add community label" took an action on this PR • (06/05/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (06/05/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/05/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Jun 05 '24 18:06 graphite-app[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jul 03 '24 00:07 github-actions[bot]

I'm going to re-draft until concerns are addressed. Feel free to mark as ready and ask for re-review until then.

zomars avatar Aug 14 '24 19:08 zomars

Thanks for the explanation, @zomars. Got it; I will update that shortly.

anikdhabal avatar Aug 15 '24 03:08 anikdhabal

E2E results are ready!

github-actions[bot] avatar Dec 06 '24 05:12 github-actions[bot]

Closing this as stale for now, branch still exists so please re-open when you pick up @anikdhabal 🙏

emrysal avatar Mar 10 '25 00:03 emrysal