cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: add retryCount to workflowReminder

Open CarinaWolli opened this issue 1 year ago • 5 comments

What does this PR do?

Right now when SMS fails to send because of whatever reason (e.g. invalid phone number), we are trying to keep scheduling it in our corn job until the date is reached. This PR introduces a retry count, after scheduling failed twice we delete the workflow reminder.

CarinaWolli avatar May 08 '24 14:05 CarinaWolli

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 1:11pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 1:11pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 1:11pm

vercel[bot] avatar May 08 '24 14:05 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar May 08 '24 14:05 github-actions[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar May 08 '24 14:05 graphite-app[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 08 '24 14:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 321 Passing - ⚠️ 24 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/13/2024 01:23:54pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c790227e0cda780e6fea9bb03af27948d9e286b9

Started: 05/13/2024 01:21:06pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user Different Locations Tests can add single organizer address location without display location public option
Retry 2Retry 1Initial Attempt
0.33% (1) 1 / 302 run
failed over last 7 days
6.29% (19) 19 / 302 runs
flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests Can add Organzer Phone Number location and book with it
Retry 2Retry 1Initial Attempt
0.33% (1) 1 / 301 run
failed over last 7 days
3.99% (12) 12 / 301 runs
flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1Initial Attempt
3.34% (10) 10 / 299 runs
failed over last 7 days
15.05% (45) 45 / 299 runs
flaked over last 7 days

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types Can create managed event type
Retry 1Initial Attempt
5.76% (17) 17 / 295 runs
failed over last 7 days
8.14% (24) 24 / 295 runs
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user -- legacy Time slots should be reserved when selected
Retry 1Initial Attempt
0% (0) 0 / 288 runs
failed over last 7 days
6.60% (19) 19 / 288 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 2Retry 1Initial Attempt
34.31% (117) 117 / 341 runs
failed over last 7 days
34.02% (116) 116 / 341 runs
flaked over last 7 days

📄   apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1Initial Attempt
0% (0) 0 / 295 runs
failed over last 7 days
44.75% (132) 132 / 295 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0.34% (1) 1 / 292 run
failed over last 7 days
40.41% (118) 118 / 292 runs
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Email verification sent if enabled
Retry 1Initial Attempt
1.31% (4) 4 / 306 runs
failed over last 7 days
19.93% (61) 61 / 306 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 1Initial Attempt
1.81% (5) 5 / 276 runs
failed over last 7 days
18.12% (50) 50 / 276 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes

Top 1 Common Error Messages

null

9 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.71% (5) 5 / 293 runs
failed over last 7 days
55.63% (163) 163 / 293 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-130.40% (-163) -163 / 125 runs
failed over last 7 days
130.40% (163) 163 / 125 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-130.40% (-163) -163 / 125 runs
failed over last 7 days
130.40% (163) 163 / 125 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-128% (-160) -160 / 125 runs
failed over last 7 days
128.80% (161) 161 / 125 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-129.84% (-161) -161 / 124 runs
failed over last 7 days
129.84% (161) 161 / 124 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-129.84% (-161) -161 / 124 runs
failed over last 7 days
129.84% (161) 161 / 124 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-129.84% (-161) -161 / 124 runs
failed over last 7 days
129.84% (161) 161 / 124 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-129.84% (-161) -161 / 124 runs
failed over last 7 days
129.84% (161) 161 / 124 runs
flaked over last 7 days
Popup Tests should open on clicking child element
Retry 1Initial Attempt
-126.83% (-156) -156 / 123 runs
failed over last 7 days
126.83% (156) 156 / 123 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 2Retry 1Initial Attempt
5.28% (16) 16 / 303 runs
failed over last 7 days
30.36% (92) 92 / 303 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Namespacing Different namespaces can have different init configs
Retry 1Initial Attempt
0% (0) 0 / 293 runs
failed over last 7 days
55.29% (162) 162 / 293 runs
flaked over last 7 days
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1Initial Attempt
0% (0) 0 / 293 runs
failed over last 7 days
54.61% (160) 160 / 293 runs
flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1Initial Attempt
1.02% (3) 3 / 293 runs
failed over last 7 days
54.95% (161) 161 / 293 runs
flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1Initial Attempt
0% (0) 0 / 293 runs
failed over last 7 days
56.31% (165) 165 / 293 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar May 08 '24 14:05 deploysentinel[bot]