cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Published 20 hours ago • verified publisher icon calcom

Refactor/conferencing app install flow

Open ibex088 opened this issue 1 year ago • 3 comments

What does this PR do?

Screenshot 2024-05-06 at 3 25 47 PM

Fixes #

LOOM

ibex088 avatar May 06 '24 09:05 ibex088

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Refactor/conferencing app install flow". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-actions[bot] avatar May 06 '24 09:05 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/installation/[[...step]] 446.39 KB 675.19 KB 192.91%

Seventy-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 411.32 KB 640.12 KB 182.89% (🟢 -0.21%)
/[user]/[type]/embed 411.32 KB 640.13 KB 182.89% (🟢 -0.21%)
/apps/[slug]/[...pages] 586.33 KB 815.13 KB 232.90% (🟢 -0.18%)
/apps/categories 255.92 KB 484.72 KB 138.49% (🟢 -0.14%)
/availability 464.04 KB 692.84 KB 197.95% (🟢 -0.19%)
/availability/[schedule] 410.39 KB 639.2 KB 182.63% (🟢 -0.21%)
/booking/[uid] 225.64 KB 454.44 KB 129.84% (🟢 -0.15%)
/booking/[uid]/embed 225.64 KB 454.45 KB 129.84% (🟢 -0.15%)
/bookings/[status] 323.67 KB 552.47 KB 157.85% (🟢 -0.16%)
/d/[link]/[slug] 411.13 KB 639.93 KB 182.84% (🟢 -0.21%)
/enterprise 255.98 KB 484.78 KB 138.51% (🟢 -0.14%)
/event-types 555.6 KB 784.4 KB 224.11% (🟢 -0.17%)
/insights 474.88 KB 703.68 KB 201.05% (🟢 -0.14%)
/more 255.48 KB 484.29 KB 138.37% (🟢 -0.14%)
/org/[orgSlug]/[user]/[type] 411.52 KB 640.32 KB 182.95% (🟢 -0.21%)
/org/[orgSlug]/[user]/[type]/embed 411.54 KB 640.35 KB 182.96% (🟢 -0.21%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 411.14 KB 639.95 KB 182.84% (🟢 -0.21%)
/org/[orgSlug]/team/[slug]/[type] 411.34 KB 640.14 KB 182.90% (🟢 -0.21%)
/settings/admin 261.56 KB 490.37 KB 140.11% (🟢 -0.15%)
/settings/admin/apps 274.65 KB 503.45 KB 143.84% (🟢 -0.15%)
/settings/admin/apps/[category] 274.63 KB 503.43 KB 143.84% (🟢 -0.16%)
/settings/admin/flags 265.67 KB 494.48 KB 141.28% (🟢 -0.14%)
/settings/admin/impersonation 261.93 KB 490.73 KB 140.21% (🟢 -0.18%)
/settings/admin/lockedSMS 282.68 KB 511.48 KB 146.14% (🟢 -0.15%)
/settings/admin/oAuth 273.72 KB 502.53 KB 143.58% (🟢 -0.14%)
/settings/admin/orgMigrations/_OrgMigrationLayout 249.93 KB 478.74 KB 136.78% (🟢 -0.18%)
/settings/admin/orgMigrations/moveTeamToOrg 299.57 KB 528.38 KB 150.96% (🟢 -0.15%)
/settings/admin/orgMigrations/moveUserToOrg 318.94 KB 547.74 KB 156.50% (🟢 -0.17%)
/settings/admin/orgMigrations/removeTeamFromOrg 299.32 KB 528.12 KB 150.89% (🟢 -0.16%)
/settings/admin/orgMigrations/removeUserFromOrg 299.33 KB 528.13 KB 150.90% (🟢 -0.16%)
/settings/admin/organizations 263.13 KB 491.93 KB 140.55% (🟢 -0.14%)
/settings/admin/organizations/[id]/edit 261.95 KB 490.75 KB 140.21% (🟢 -0.14%)
/settings/admin/users 263.81 KB 492.61 KB 140.75% (🟢 -0.15%)
/settings/admin/users/[id]/edit 392.43 KB 621.24 KB 177.50% (🟢 -0.16%)
/settings/admin/users/add 392.16 KB 620.97 KB 177.42% (🟢 -0.16%)
/settings/billing 261.67 KB 490.47 KB 140.14% (🟢 -0.15%)
/settings/developer/api-keys 265.72 KB 494.53 KB 141.29% (🟢 -0.14%)
/settings/developer/webhooks 265.8 KB 494.6 KB 141.32% (🟢 -0.15%)
/settings/developer/webhooks/[id] 266.81 KB 495.62 KB 141.61% (🟢 -0.15%)
/settings/developer/webhooks/new 266.81 KB 495.61 KB 141.60% (🟢 -0.14%)
/settings/my-account/appearance 314.47 KB 543.27 KB 155.22% (🟢 -0.16%)
/settings/my-account/general 377.45 KB 606.25 KB 173.21% (🟢 -0.14%)
/settings/my-account/out-of-office 266.35 KB 495.15 KB 141.47% (🟢 -0.14%)
/settings/my-account/profile 404.97 KB 633.77 KB 181.08% (🟢 -0.14%)
/settings/organizations/appearance 285.63 KB 514.43 KB 146.98% (🟢 -0.14%)
/settings/organizations/billing 261.75 KB 490.55 KB 140.16% (🟢 -0.14%)
/settings/organizations/general 349.26 KB 578.06 KB 165.16% (🟢 -0.19%)
/settings/organizations/platform/oauth-clients 264.24 KB 493.05 KB 140.87% (🟢 -0.14%)
/settings/organizations/platform/oauth-clients/create 264.42 KB 493.22 KB 140.92% (🟢 -0.14%)
/settings/organizations/privacy 267.34 KB 496.14 KB 141.75% (🟢 -0.14%)
/settings/organizations/profile 397.74 KB 626.54 KB 179.01% (🟢 -0.14%)
/settings/organizations/sso 272.41 KB 501.22 KB 143.21% (🟢 -0.15%)
/settings/organizations/teams/other 262.32 KB 491.12 KB 140.32% (🟢 -0.14%)
/settings/organizations/teams/other/[id]/appearance 274.46 KB 503.26 KB 143.79% (🟢 -0.14%)
/settings/organizations/teams/other/[id]/members 269.41 KB 498.21 KB 142.35% (🟢 -0.14%)
/settings/organizations/teams/other/[id]/profile 468.15 KB 696.95 KB 199.13% (🟢 -0.14%)
/settings/security/impersonation 266.57 KB 495.38 KB 141.54% (🟢 -0.15%)
/settings/security/password 304.08 KB 532.88 KB 152.25% (🟢 -0.16%)
/settings/security/sso 271.74 KB 500.54 KB 143.01% (🟢 -0.14%)
/settings/security/two-factor-auth 270 KB 498.8 KB 142.52% (🟢 -0.15%)
/settings/teams 261.23 KB 490.04 KB 140.01% (🟢 -0.14%)
/settings/teams/[id]/appearance 274.45 KB 503.25 KB 143.79% (🟢 -0.15%)
/settings/teams/[id]/billing 261.75 KB 490.55 KB 140.16% (🟢 -0.15%)
/settings/teams/[id]/members 379.33 KB 608.13 KB 173.75% (🟢 -0.17%)
/settings/teams/[id]/profile 468.98 KB 697.78 KB 199.37% (🟢 -0.14%)
/team/[slug]/[type] 411.31 KB 640.11 KB 182.89% (🟢 -0.21%)
/team/[slug]/[type]/embed 411.34 KB 640.14 KB 182.90% (🟢 -0.21%)
/teams 255.71 KB 484.51 KB 138.43% (🟢 -0.14%)
/upgrade 255.83 KB 484.63 KB 138.47% (🟢 -0.14%)
/workflows 287.13 KB 515.93 KB 147.41% (🟢 -0.15%)
/workflows/[workflow] 409.48 KB 638.29 KB 182.37% (🟢 -0.18%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 06 '24 10:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 297 Passing - ❌ 7 Failing - ⚠️ 12 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/07/2024 04:33:46pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5dcad4fb708e74cef99256661672883e330c4072

Started: 05/07/2024 04:30:42pm UTC

❌ Failures

📄   packages/app-store/typeform/playwright/tests/basic.e2e.ts • 2 Failures

Top 1 Common Error Messages

page.waitForURL: Timeout 30000ms exceeded.

 2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Typeform App Typeform Redirect Link should copy link in editing area
Retry 2 • Retry 1 • Initial Attempt
Error: page.waitForURL: Timeout 30000ms exceeded.... 
page.waitForURL: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for navigation until "load"
  navigated to "http://localhost:3000/apps/installed/automation?hl=typeform"
============================================================
1.20% (4) 4 / 334 runs
failed over last 7 days
0.30% (1) 1 / 334 run
flaked over last 7 days
Typeform App Typeform Redirect Link should copy link in RoutingForms list
Retry 2 • Retry 1 • Initial Attempt
Error: page.waitForURL: Timeout 30000ms exceeded.... 
page.waitForURL: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for navigation until "load"
  navigated to "http://localhost:3000/apps/installed/automation?hl=typeform"
============================================================
1.20% (4) 4 / 334 runs
failed over last 7 days
0.30% (1) 1 / 334 run
flaked over last 7 days
📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration with the new app install flow skip flase When event is paid and confirmed skip false Payment should confirm pending payment booking skip false
Initial Attempt
Error: page.waitForURL: Timeout 30000ms exceeded.... 
page.waitForURL: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for navigation to "event-types" until "load"
============================================================
16.67% (1) 1 / 6 run
failed over last 7 days
0% (0) 0 / 6 runs
flaked over last 7 days
📄   apps/web/playwright/apps/analytics/analyticsApps.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Check analytics Apps Check analytics Apps using the new flow
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=\'fathom-app-switch\'][data-state="checked"]')
  - waiting for locator('[data-testid=\'fathom-app-switch\'][data-state="checked"]')
37.50% (3) 3 / 8 runs
failed over last 7 days
0% (0) 0 / 8 runs
flaked over last 7 days
📄   apps/web/playwright/availability.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity Date Overrides
Retry 2 • Retry 1 • Initial Attempt
Error: expect(received).toHaveCount(expected) // deep equality... 
expect(received).toHaveCount(expected) // deep equality

Expected: 1
Received: 0
Call log:
  - expect.toHaveCount with timeout 30000ms
  - waiting for locator('[data-testid="troubleshooter-busy-time"]')
  -   locator resolved to 0 elements
  -   unexpected value "0"
  - waiting for locator('[data-testid="troubleshooter-busy-time"]')
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
25.07% (86) 86 / 343 runs
failed over last 7 days
1.46% (5) 5 / 343 runs
flaked over last 7 days
📄   apps/web/playwright/webhook.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
BOOKING_RESCHEDULED when rescheduling to a booking that already exists, should send a booking rescheduled event with the existant booking uid
Retry 2 • Retry 1 • Initial Attempt
Error: expect(received).not.toBeNull()... 
expect(received).not.toBeNull()

Received: null
6.71% (21) 21 / 313 runs
failed over last 7 days
30.67% (96) 96 / 313 runs
flaked over last 7 days
📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 2 • Retry 1 • Initial Attempt
Error: Expected to provide an iframe, got null 
Expected to provide an iframe, got null
16.96% (58) 58 / 342 runs
failed over last 7 days
39.47% (135) 135 / 342 runs
flaked over last 7 days

⚠️ Flakes

📄   apps/web/playwright/hash-my-url.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
hash my url generate url hash
Retry 1 • Initial Attempt
5.28% (16) 16 / 303 runs
failed over last 7 days
29.37% (89) 89 / 303 runs
flaked over last 7 days
📄   apps/web/playwright/settings/upload-avatar.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
User Avatar it can upload a user profile image
Retry 1 • Initial Attempt
0% (0) 0 / 359 runs
failed over last 7 days
0.56% (2) 2 / 359 runs
flaked over last 7 days
📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

 2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt
10.50% (36) 36 / 343 runs
failed over last 7 days
8.75% (30) 30 / 343 runs
flaked over last 7 days
Event Types tests -- legacy user can add multiple organizer address
Retry 1 • Initial Attempt
0.30% (1) 1 / 333 run
failed over last 7 days
2.40% (8) 8 / 333 runs
flaked over last 7 days
📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt
20.88% (71) 71 / 340 runs
failed over last 7 days
32.06% (109) 109 / 340 runs
flaked over last 7 days
📄   apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests Should load Valid Cal video url after rescheduling Opt in events
Retry 1 • Initial Attempt
9.47% (34) 34 / 359 runs
failed over last 7 days
0.84% (3) 3 / 359 runs
flaked over last 7 days
📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity Can manage single schedule
Retry 1 • Initial Attempt
0% (0) 0 / 343 runs
failed over last 7 days
0.58% (2) 2 / 343 runs
flaked over last 7 days
📄   packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

 4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt
0.90% (3) 3 / 332 runs
failed over last 7 days
51.51% (171) 171 / 332 runs
flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt
0% (0) 0 / 332 runs
failed over last 7 days
52.11% (173) 173 / 332 runs
flaked over last 7 days
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt
0% (0) 0 / 332 runs
failed over last 7 days
51.51% (171) 171 / 332 runs
flaked over last 7 days
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt
0.60% (2) 2 / 332 runs
failed over last 7 days
50.90% (169) 169 / 332 runs
flaked over last 7 days
📄   apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1 • Initial Attempt
0% (0) 0 / 309 runs
failed over last 7 days
18.77% (58) 58 / 309 runs
flaked over last 7 days

View Detailed Build Results

deploysentinel[bot] avatar May 06 '24 10:05 deploysentinel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 4:18pm
cal ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 4:18pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 4:18pm

vercel[bot] avatar May 07 '24 11:05 vercel[bot]