fix: buffer times in handleNewBooking

[CarinaWolli]

trafficstars

What does this PR do?

Fixes the issue that bookings could be made without respecting before or after buffers of other existing bookings. Slots are shown correctly, but when you changed the slot URL param to a time that is within a buffer handleNewBooking didn't throw an error and instead, the booking was successful.

Fixes #14868 Fixes https://linear.app/calcom/issue/CAL-3631/buffer-times-not-respected-when-url-param-is-changed

[linear[bot]]

CAL-3631 Buffer times not respected when URL param is changed

[github-actions[bot]]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 9, 2024 9:24am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		May 9, 2024 9:24am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		May 9, 2024 9:24am

[graphite-app[bot]]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/03/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 34 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/09/2024 01:38:30pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f9caa274211cc18daadb5e7b4325fce374181f3f

Started: 05/09/2024 01:37:33pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Can resend verification link if the secondary email is unverified Retry 1 • Initial Attempt	10.83% (38) 38 / 351 runs failed over last 7 days	25.64% (90) 90 / 351 runs flaked over last 7 days

---

View Detailed Build Results

---

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[sean-brydon]

I added a before event buffer of 60 minute in this event type and booked 3:00 PM - 3:15 PM Slot on 10th

but the slots 3:15. 3:30, 3:45, ... are missing. is this expected behaviour?

I think this is right? You need 60 minutes BEFORE your next event so thus 3:00-3:15 should block till 4:15 which is what i think this is doing.

[CarinaWolli]

I added a before event buffer of 60 minute in this event type and booked 3:00 PM - 3:15 PM Slot on 10th but the slots 3:15. 3:30, 3:45, ... are missing. is this expected behaviour?

I think this is right? You need 60 minutes BEFORE your next event so thus 3:00-3:15 should block till 4:15 which is what i think this is doing.

Exactly!