cal.com
cal.com copied to clipboard
fix: meeting ended and started webhooks trigger
What does this PR do?
Fixes # (issue)
Requirement/Documentation
- If there is a requirement document, please, share it here.
- If there is a UI/UX design document, please, share it here.
Type of change
- Bug fix (non-breaking change which fixes an issue)
- Chore (refactoring code, technical debt, workflow improvements)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- Tests (Unit/Integration/E2E or any other test)
- This change requires a documentation update
How should this be tested?
- Are there environment variables that should be set?
- What are the minimal test data to have?
- What is expected (happy path) to have (input and output)?
- Any other important info that could help to test that PR
Mandatory Tasks
- [ ] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.
Checklist
- I haven't read the contributing guide
- My code doesn't follow the style guidelines of this project
- I haven't commented my code, particularly in hard-to-understand areas
- I haven't checked if my PR needs changes to the documentation
- I haven't checked if my changes generate no new warnings
- I haven't added tests that prove my fix is effective or that my feature works
- I haven't checked if new and existing unit tests pass locally with my changes
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ai | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 10, 2024 1:36pm |
2 Ignored Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cal | ⬜️ Ignored (Inspect) | Visit Preview | May 10, 2024 1:36pm | |
| calcom-web-canary | ⬜️ Ignored (Inspect) | Visit Preview | May 10, 2024 1:36pm |
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
Current Playwright Test Results Summary
✅ 321 Passing - ⚠️ 8 Flaky
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 05/10/2024 01:50:19pm UTC)
Run Details
Running Workflow PR Update on Github Actions
Commit: b6edd2773b098a5f7bbe0b591ff4d7f84aa2d846
Started: 05/10/2024 01:46:15pm UTC
⚠️ Flakes
📄 apps/web/playwright/teams.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2 • Retry 1 • Initial Attempt |
3.93% (12)12 / 305 runsfailed over last 7 days |
19.67% (60)60 / 305 runsflaked over last 7 days |
|
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 2 • Retry 1 • Initial Attempt |
6.89% (21)21 / 305 runsfailed over last 7 days |
30.82% (94)94 / 305 runsflaked over last 7 days |
📄 apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1 • Initial Attempt |
0% (0)0 / 296 runsfailed over last 7 days |
37.84% (112)112 / 296 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings
Retry 1 • Initial Attempt |
8.33% (1)1 / 12 runfailed over last 7 days |
50% (6)6 / 12 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can verify the newly added secondary email
Retry 2 • Retry 1 • Initial Attempt |
1.46% (5)5 / 342 runsfailed over last 7 days |
20.76% (71)71 / 342 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 299 runsfailed over last 7 days |
55.85% (167)167 / 299 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
18.15% (57)57 / 314 runsfailed over last 7 days |
39.49% (124)124 / 314 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0% (0)0 / 297 runsfailed over last 7 days |
12.12% (36)36 / 297 runsflaked over last 7 days |
Graphite Automations
"Add consumer team as reviewer" took an action on this PR • (05/07/24)
1 reviewer was added to this PR based on Keith Williams's automation.