cal.com
cal.com copied to clipboard
fix: Booking Cancelled Webhook - Organiser webhook payload is missing id. #14697
Fixes: #14697
What does this PR do?
fixes the missing id
and username
information that is available on the Created and Rescheduled webhook payloads.
@vikaspatil0021 is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
Graphite Automations
"Add community label" took an action on this PR • (04/25/24)
1 label was added to this PR based on Keith Williams's automation.
"Add consumer team as reviewer" took an action on this PR • (04/25/24)
1 reviewer was added to this PR based on Keith Williams's automation.
"Add foundation team as reviewer" took an action on this PR • (04/26/24)
1 reviewer was added to this PR based on Keith Williams's automation.
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
@alishaz-polymath Please review.
Hey @Udit-takkar, https://github.com/calcom/cal.com/blob/8fbb1ed4260449a0e07260283b16122b834e2a59/apps/web/test/utils/bookingScenario/bookingScenario.ts#L942
https://github.com/calcom/cal.com/blob/8fbb1ed4260449a0e07260283b16122b834e2a59/packages/features/bookings/lib/handleSeats/test/handleSeats.test.ts#L1389
here organizer
structure is different and id
already exists. should i add username
to them?
here
organizer
structure is different andid
already exists. should i addusername
to them?
No not here. check expectBookingCreatedWebhookToHaveBeenFired
function in apps/web/test/utils/bookingScenario/expects.ts. create a similar function to check booking cancelled webhook
@Udit-takkar Please check
@vikaspatil0021 use prettier and then push the code. getting lint error in CI
@Udit-takkar Please check