fix: Impersonation flicker on timezone change

[emrysal]

What does this PR do?

• Removes dependency on IS_VISUAL_REGRESSION_TESTING - instead we set a global cookie that disables the timezone change popup. It is possible to remove this cookie to confirm the timezone change works properly (but maybe best tested with vitest and not e2e).
• Extract DialogContent for improved performance of Shell
• Extract open/setOpen to custom hook for clarity & also performance

[github-actions[bot]]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

[graphite-app[bot]]

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
platform-starter-kit	❌ Failed (Inspect)			Apr 24, 2024 9:04pm

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview		Apr 24, 2024 9:04pm
cal	⬜️ Ignored (Inspect)	Visit Preview		Apr 24, 2024 9:04pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Apr 24, 2024 9:04pm

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/auth/setup	148.64 KB	377.05 KB	107.73% (🟢 -0.14%)
/settings/admin/oAuth	272 KB	500.41 KB	142.97% (🟢 -0.25%)
/settings/admin/oAuth/oAuthView	94.13 KB	322.54 KB	92.16% (🟢 -0.23%)
/settings/admin/orgMigrations/moveTeamToOrg	298.08 KB	526.49 KB	150.43% (🟢 -0.19%)
/settings/admin/orgMigrations/moveUserToOrg	317.34 KB	545.75 KB	155.93% (🟢 -0.20%)
/settings/admin/orgMigrations/removeTeamFromOrg	297.86 KB	526.27 KB	150.36% (🟢 -0.17%)
/settings/admin/orgMigrations/removeUserFromOrg	297.88 KB	526.29 KB	150.37% (🟢 -0.17%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 314 Passing - ⚠️ 13 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/24/2024 09:14:07pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: af3dcc16624e1ce150e2d8f6f8435c2020880089

Started: 04/24/2024 09:10:08pm UTC

⚠️ Flakes

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members Retry 2 • Retry 1 • Initial Attempt	5.69% (16) 16 / 281 runs failed over last 7 days	33.45% (94) 94 / 281 runs flaked over last 7 days

---

📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user Different Locations Tests Can remove location from multiple locations that are saved Retry 1 • Initial Attempt	17.54% (47) 47 / 268 runs failed over last 7 days	6.34% (17) 17 / 268 runs flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved Retry 1 • Initial Attempt	0.45% (1) 1 / 222 run failed over last 7 days	27.93% (62) 62 / 222 runs flaked over last 7 days

---

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Availablity it can delete date overrides Retry 1 • Initial Attempt	0% (0) 0 / 274 runs failed over last 7 days	1.46% (4) 4 / 274 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Preview Preview - embed-core should load Retry 1 • Initial Attempt	0% (0) 0 / 272 runs failed over last 7 days	43.75% (119) 119 / 272 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null	8 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	17.10% (46) 46 / 269 runs failed over last 7 days	52.04% (140) 140 / 269 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	-168.67% (-140) -140 / 83 runs failed over last 7 days	168.67% (140) 140 / 83 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	-167.47% (-139) -139 / 83 runs failed over last 7 days	167.47% (139) 139 / 83 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	-166.27% (-138) -138 / 83 runs failed over last 7 days	167.47% (139) 139 / 83 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API Retry 1 • Initial Attempt	-169.51% (-139) -139 / 82 runs failed over last 7 days	169.51% (139) 139 / 82 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-169.51% (-139) -139 / 82 runs failed over last 7 days	169.51% (139) 139 / 82 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-169.51% (-139) -139 / 82 runs failed over last 7 days	169.51% (139) 139 / 82 runs flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it Retry 1 • Initial Attempt	-169.51% (-139) -139 / 82 runs failed over last 7 days	169.51% (139) 139 / 82 runs flaked over last 7 days

---

View Detailed Build Results

---