cal.com
cal.com copied to clipboard
chore: Remove deprecated logo/avatar/away fields
What does this PR do?
- Drops away, avatar fields from
users - Drops logo field from
Team
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ai | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 5, 2024 1:57pm |
| platform-starter-kit | ❌ Failed (Inspect) | Jun 5, 2024 1:57pm |
2 Ignored Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cal | ⬜️ Ignored (Inspect) | Visit Preview | Jun 5, 2024 1:57pm | |
| calcom-web-canary | ⬜️ Ignored (Inspect) | Visit Preview | Jun 5, 2024 1:57pm |
Graphite Automations
"Add foundation team as reviewer" took an action on this PR • (04/22/24)
1 reviewer was added to this PR based on Keith Williams's automation.
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
Current Playwright Test Results Summary
✅ 69 Passing - ❌ 1 Failing - ⚠️ 1 Flaky
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 06/04/2024 11:05:54pm UTC)
Run Details
Running Workflow All checks on Github Actions
Commit: 9e317576bade8d1dbd5097204e49c0cb1bdfe5ac
Started: 06/04/2024 11:02:44pm UTC
❌ Failures
📄 apps/web/playwright/workflow.e2e.ts • 1 Failure
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Workflow Tab - Event Type Check the functionalities of the Workflow Tab User Workflows Creating a new workflow
Retry 2 • Retry 1 • Initial Attempt Error: expect(received).toHaveCount(expected) // deep equality...
|
1.29% (2)2 / 155 runsfailed over last 7 days |
0.65% (1)1 / 155 runflaked over last 7 days |
⚠️ Flakes
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Newly added secondary email should show as Unverified
Retry 2 • Retry 1 • Initial Attempt |
3.82% (6)6 / 157 runsfailed over last 7 days |
35.67% (56)56 / 157 runsflaked over last 7 days |
Why do all e2e tests fail here? I already tried re-running them 🤔
Deployment failed with the following error:
Too many requests - try again in 1 minute (more than 60, code: "api-deployments-flood").
@emrysal Looks like e2e 6/7 are failing consistently. Might need to look into it a bit more
what do we do here @emrysal @keithwillcode
@emrysal Do we need to make 2 separate PRs here?
- Remove the fields from the schema
- Drop the columns
Will dropping the columns before the deployment hits production start throwing errors if queries are still using the schema will these 3 fields?
So I don't think this is needed if there are no usages, but if there are there must be two PRs - unfortunately since the PR removing all logo/avatar uses this has sneaked back in. I've reverted this in this PR however this does mean two PRs are required after all.
No problem, I'll remove the migration files, then do another PR.
@emrysal there is a missing migration in the main branch after this was merged