cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

chore: Remove deprecated logo/avatar/away fields

Open emrysal opened this issue 1 year ago • 8 comments

What does this PR do?

  • Drops away, avatar fields from users
  • Drops logo field from Team

emrysal avatar Apr 22 '24 17:04 emrysal

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Apr 22 '24 17:04 github-actions[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 1:57pm
platform-starter-kit ❌ Failed (Inspect) Jun 5, 2024 1:57pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 1:57pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 1:57pm

vercel[bot] avatar Apr 22 '24 17:04 vercel[bot]

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/22/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Apr 22 '24 17:04 graphite-app[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Apr 22 '24 17:04 github-actions[bot]

Current Playwright Test Results Summary

✅ 69 Passing - ❌ 1 Failing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/04/2024 11:05:54pm UTC)

Run Details

Running Workflow All checks on Github Actions

Commit: 9e317576bade8d1dbd5097204e49c0cb1bdfe5ac

Started: 06/04/2024 11:02:44pm UTC

❌ Failures

📄   apps/web/playwright/workflow.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Workflow Tab - Event Type Check the functionalities of the Workflow Tab User Workflows Creating a new workflow
Retry 2Retry 1Initial Attempt
Error: expect(received).toHaveCount(expected) // deep equality...
expect(received).toHaveCount(expected) // deep equality

Expected: 3
Received: 0
Call log:
  - expect.toHaveCount with timeout 30000ms
  - waiting for locator('[data-testid="workflow-list"] > li')
  -   locator resolved to 0 elements
  -   unexpected value "0"
  - waiting for locator('[data-testid="workflow-list"] > li')
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"

1.29% (2) 2 / 155 runs
failed over last 7 days
0.65% (1) 1 / 155 run
flaked over last 7 days

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Newly added secondary email should show as Unverified
Retry 2Retry 1Initial Attempt
3.82% (6) 6 / 157 runs
failed over last 7 days
35.67% (56) 56 / 157 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Apr 22 '24 17:04 deploysentinel[bot]

Why do all e2e tests fail here? I already tried re-running them 🤔

CarinaWolli avatar Apr 23 '24 19:04 CarinaWolli

Deployment failed with the following error:

Too many requests - try again in 1 minute (more than 60, code: "api-deployments-flood").

vercel[bot] avatar May 02 '24 14:05 vercel[bot]

@emrysal Looks like e2e 6/7 are failing consistently. Might need to look into it a bit more

keithwillcode avatar May 06 '24 21:05 keithwillcode

what do we do here @emrysal @keithwillcode

PeerRich avatar Jun 03 '24 14:06 PeerRich

@emrysal Do we need to make 2 separate PRs here?

  1. Remove the fields from the schema
  2. Drop the columns

Will dropping the columns before the deployment hits production start throwing errors if queries are still using the schema will these 3 fields?

So I don't think this is needed if there are no usages, but if there are there must be two PRs - unfortunately since the PR removing all logo/avatar uses this has sneaked back in. I've reverted this in this PR however this does mean two PRs are required after all.

No problem, I'll remove the migration files, then do another PR.

emrysal avatar Jun 04 '24 22:06 emrysal

@emrysal there is a missing migration in the main branch after this was merged

Udit-takkar avatar Jun 06 '24 08:06 Udit-takkar