cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Add Hungarian support

Open zomars opened this issue 10 months ago • 8 comments

What does this PR do?

  • Enables Hungarian support in language selector
  • Sorts locales alphabetically

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • In account settings, select Hungarian and test for anomalies.

Mandatory Tasks

  • [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

zomars avatar Apr 09 '24 19:04 zomars

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform-starter-kit ❌ Failed (Inspect) Jun 21, 2024 11:26am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 11:26am
cal ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 11:26am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 11:26am

vercel[bot] avatar Apr 09 '24 19:04 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Apr 09 '24 19:04 github-actions[bot]

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Apr 09 '24 20:04 graphite-app[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Apr 09 '24 20:04 github-actions[bot]

Current Playwright Test Results Summary

✅ 0 Passing - ❌ 5 Failing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/20/2024 05:22:00pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: b264efe32f29d230be4cad803f58a4d1e42f74f5

Started: 05/20/2024 05:21:25pm UTC

❌ Failures

📄   packages/app-store/typeform/playwright/tests/basic.e2e.ts • 2 Failures

Top 1 Common Error Messages

apiRequestContext.get: connect ECONNREFUSED ::1:3000

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Typeform App Typeform Redirect Link should copy link in editing area
Retry 2Retry 1Initial Attempt
Error: apiRequestContext.get: connect ECONNREFUSED ::1:3000...
apiRequestContext.get: connect ECONNREFUSED ::1:3000
=========================== logs ===========================
→ GET http://localhost:3000/api/auth/csrf
  user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.5563.19 Safari/537.36
  accept: */*
  accept-encoding: gzip,deflate,br
  cookie: calcom-timezone-dialog=1
============================================================
2.01% (5) 5 / 249 runs
failed over last 7 days
0.40% (1) 1 / 249 run
flaked over last 7 days
Typeform App Typeform Redirect Link should copy link in RoutingForms list
Retry 2Retry 1Initial Attempt
Error: apiRequestContext.get: connect ECONNREFUSED ::1:3000...
apiRequestContext.get: connect ECONNREFUSED ::1:3000
=========================== logs ===========================
→ GET http://localhost:3000/api/auth/csrf
  user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.5563.19 Safari/537.36
  accept: */*
  accept-encoding: gzip,deflate,br
  cookie: calcom-timezone-dialog=1
============================================================
2.01% (5) 5 / 249 runs
failed over last 7 days
0.80% (2) 2 / 249 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Failures

Top 1 Common Error Messages

apiRequestContext.get: connect ECONNREFUSED ::1:3000

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Zero State Routing Forms should be able to edit the form
Retry 2Retry 1Initial Attempt
Error: apiRequestContext.get: connect ECONNREFUSED ::1:3000...
apiRequestContext.get: connect ECONNREFUSED ::1:3000
=========================== logs ===========================
→ GET http://localhost:3000/api/auth/csrf
  user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.5563.19 Safari/537.36
  accept: */*
  accept-encoding: gzip,deflate,br
  cookie: calcom-timezone-dialog=1
============================================================
1.21% (3) 3 / 247 runs
failed over last 7 days
0% (0) 0 / 247 runs
flaked over last 7 days
Routing Forms Zero State Routing Forms should be able to add a new form and view it
Retry 2Retry 1Initial Attempt
Error: apiRequestContext.get: connect ECONNREFUSED ::1:3000...
apiRequestContext.get: connect ECONNREFUSED ::1:3000
=========================== logs ===========================
→ GET http://localhost:3000/api/auth/csrf
  user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.5563.19 Safari/537.36
  accept: */*
  accept-encoding: gzip,deflate,br
  cookie: calcom-timezone-dialog=1
============================================================
1.21% (3) 3 / 247 runs
failed over last 7 days
0% (0) 0 / 247 runs
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Signup with valid (non premium) username
Retry 1Initial Attempt
Error: page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:3000/signup...
page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:3000/signup
=========================== logs ===========================
navigating to "http://localhost:3000/signup", waiting until "load"
============================================================
1.53% (4) 4 / 262 runs
failed over last 7 days
0% (0) 0 / 262 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Apr 09 '24 20:04 deploysentinel[bot]

Deployment failed with the following error:

Too many requests - try again in 32 seconds (more than 60, code: "api-deployments-flood").

vercel[bot] avatar May 02 '24 14:05 vercel[bot]

@zomars there is a test for locale that's failing consistently. Don't think it's an e2e flake but rather an actual thing we need to investigate in the test

This is very odd indeed since this is an one file change. Will investigate

zomars avatar May 06 '24 22:05 zomars

What preventing this single line code change to be merged? Is there anything I can help? Is it related to an another problem?

kissgyula avatar May 24 '24 13:05 kissgyula

What preventing this single line code change to be merged? Is there anything I can help? Is it related to an another problem?

we dont know why this is breaking our E2E to be fair

PeerRich avatar Jun 01 '24 21:06 PeerRich

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jun 18 '24 00:06 github-actions[bot]

Fixed the test. Should be mergeable now.

hariombalhara avatar Jun 21 '24 11:06 hariombalhara

Fixed the test. Should be mergeable now.

Thank you, @hariombalhara! This one had been lingering for quite some time. Nice to see it go through.

keithwillcode avatar Jun 21 '24 12:06 keithwillcode